Skip to content

chore(deps): add umap-learn and scikit-learn for the image map - #36

Open
lstein wants to merge 1 commit into
feat/image-map-02-indexerfrom
feat/image-map-03-deps
Open

chore(deps): add umap-learn and scikit-learn for the image map#36
lstein wants to merge 1 commit into
feat/image-map-02-indexerfrom
feat/image-map-03-deps

Conversation

@lstein

@lstein lstein commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Stacked on the indexer PR (PR 3 of the Image Map stack). Dependencies only:

  • umap-learn~=0.5.7 (resolves 0.5.12; pulls pynndescent/llvmlite/numba)
  • scikit-learn~=1.5 (resolves 1.9.0) for DBSCAN
  • numba>=0.59,<0.62 guard (resolves 0.61.2) — numba releases tighten numpy bounds and this project pins numpy<2.0 (locked 1.26.4)

Isolated in its own PR because the numba/llvmlite install matrix is the most likely thing to break CI or downstream installs; reverting/adjusting stays trivial.

Testing

tests/app/services/image_index/test_umap_import.py fits a tiny UMAP + DBSCAN so CI fails loudly here — rather than in feature code — if the JIT stack is broken (also surfaces the cold-cache JIT cost).

🤖 Generated with Claude Code

@lstein
lstein requested a review from blessedcoolant as a code owner August 2, 2026 20:36
@lstein
lstein marked this pull request as draft August 2, 2026 22:23
@lstein
lstein force-pushed the feat/image-map-03-deps branch 2 times, most recently from fdb7e82 to b86155a Compare August 3, 2026 01:38
@lstein
lstein force-pushed the feat/image-map-02-indexer branch from 1bc499a to c5cc29c Compare August 3, 2026 01:38
@lstein
lstein marked this pull request as ready for review August 3, 2026 18:28
@lstein
lstein force-pushed the feat/image-map-02-indexer branch from c5cc29c to 7ea889c Compare August 4, 2026 01:43
@lstein
lstein force-pushed the feat/image-map-03-deps branch from b86155a to 3b0243b Compare August 4, 2026 01:43
@lstein
lstein force-pushed the feat/image-map-02-indexer branch from 7ea889c to 5ca27a0 Compare August 4, 2026 05:37
@lstein
lstein force-pushed the feat/image-map-03-deps branch from 3b0243b to 99ff815 Compare August 4, 2026 05:37
@lstein
lstein force-pushed the feat/image-map-02-indexer branch from 5ca27a0 to 4a7793d Compare August 4, 2026 14:58
@lstein
lstein force-pushed the feat/image-map-03-deps branch 2 times, most recently from 086926d to 178f253 Compare August 4, 2026 22:32
@lstein
lstein force-pushed the feat/image-map-02-indexer branch from 4a7793d to 8412295 Compare August 4, 2026 22:32
Adds the projection/clustering dependencies for the semantic image map:
umap-learn (resolves 0.5.12, pulling pynndescent/llvmlite) and
scikit-learn (resolves 1.9.0) for DBSCAN. numba is guarded to >=0.59,<0.62
because numba releases tighten numpy bounds and this project pins
numpy<2.0 (currently 1.26.4; numba resolves 0.61.2).

A smoke test fits a tiny UMAP + DBSCAN so CI fails loudly here — rather
than in feature code — if the numba/llvmlite install matrix breaks.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@lstein
lstein force-pushed the feat/image-map-02-indexer branch from 8412295 to ad8d3f1 Compare August 5, 2026 00:31
@lstein
lstein force-pushed the feat/image-map-03-deps branch from 178f253 to 41592b3 Compare August 5, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant