style(types): integrate arethetypeswrong for local and CI verification

[mikehardy]

Description

Adds scoped published-types verification with @arethetypeswrong/cli for local use (yarn attw:check) and CI (new attw job in linting.yml).

Scope follows our consumer matrix (Types-AD-1..4 in okf-bundle/testing/architecture-decisions.md):

• Primary gate remains yarn tsc:compile:consumer (moduleResolution: bundler).
• attw uses .attw.json (esm-only profile; ignore internal-resolution-error and cjs-resolves-to-esm) — Node10/Node16-CJS modes and extensionless .d.ts relative imports are out of scope for RN/Metro consumers.
• Expo config plugins get a packed-consumer smoke test (npm pack → temp install → require('<pkg>/app.plugin.js')), not attw exclusion.

Companion commit refactors Expo plugins: plugin/src/app.plugin.ts compiles to plugin/build/app.plugin.{js,d.ts}; package root keeps a one-line app.plugin.js shim; exports wire ./app.plugin and ./app.plugin.js types to the built entry.

Related issues

N/A — proactive types hygiene / CI gate.

Release Summary

No user-facing runtime changes. Published Expo plugin type exports and CI type-checking coverage improved.

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
  • Other (macOS, web) — tooling / published package types / Expo config plugins
• My change includes tests;
  • e2e tests added or updated in packages/**/e2e
  • jest tests added or updated in packages/**/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

• yarn attw:check — all 19 published packages pass scoped attw; Expo plugin consumer smoke passes
• yarn lerna run build:plugin --scope '@react-native-firebase/{app,analytics,auth,messaging,crashlytics,perf,app-check,app-distribution}' before attw (plugin/build artifacts)

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[cursor]

Bugbot is not enabled for this team, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a robust type-checking gate using attw to ensure published package types align with the project's consumer matrix. It also standardizes Expo config plugin structures, ensuring they are correctly exported and smoke-tested during the CI process to prevent regressions in library consumption.

Highlights

• Tooling Integration: Integrated @arethetypeswrong/cli (attw) to provide automated verification of published package types for both local development and CI pipelines.
• Expo Plugin Refactor: Refactored Expo config plugins to improve type exports and added a smoke test suite to ensure runtime compatibility during CI.
• Documentation: Added a new Architecture Decision Record (ADR) to document the type-checking strategy, consumer matrix, and CI gates.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/linting.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a validation script to check published package types using @arethetypeswrong/cli (attw) and smoke-tests Expo config plugins, alongside updating package exports and documentation. The reviewer feedback is highly actionable and identifies several key improvements for the validation script, including refactoring shell executions from execSync to spawnSync to prevent OS-specific parsing issues, updating yarn pack commands to use Yarn v4 compatible flags (--out instead of --filename), removing a non-existent @expo/config-plugins version specifier that would cause CI failures, and filtering out private packages from the check.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.62%. Comparing base (1bad118) to head (99fc7a8).

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9098      +/-   ##
============================================
- Coverage     58.66%   58.62%   -0.04%     
  Complexity     1617     1617              
============================================
  Files           503      503              
  Lines         39180    39180              
  Branches       5807     5807              
============================================
- Hits          22981    22965      -16     
- Misses        14800    14812      +12     
- Partials       1399     1403       +4     

Flag	Coverage Δ
android-native	53.57% <ø> (ø)
e2e-ts-android	49.98% <ø> (-0.02%)	⬇️
e2e-ts-ios	53.89% <ø> (-0.06%)	⬇️
e2e-ts-macos	41.48% <ø> (-<0.01%)	⬇️
ios-native	53.89% <ø> (-0.06%)	⬇️
jest	49.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mikehardy]

@gemini-code-assist — all review feedback addressed in b60d54172 (amended into lint(types)). Summary:

Feedback	Action
spawnSync over execSync (runAttw, checkExpoPlugins)	✅ Accepted — all child processes now use spawnSync with argument arrays, no shell
yarn pack --out (Yarn v4)	✅ Accepted — both pack call sites
Remove @expo/config-plugins@54 pin	✅ Accepted — unpinned intentionally as early-warning canary for Expo API drift; smoke passes against latest (57.x). Note: v54 does exist on npm — this is drift detection, not a missing-version fix
Filter private packages	✅ Accepted — listPublishedPackages() skips "private": true
Drop temp JSON file / parse stdout directly	❌ Declined — kept file-descriptor capture (stdio: ['ignore', outFd, 'pipe']) to guarantee no maxBuffer truncation on large attw reports

Verified: yarn attw:check passes locally with all changes.

[gemini-code-assist]

Thanks for the update, Mike. The changes look solid. Your reasoning for keeping the file-descriptor capture for the attw output is spot on—it's a much more robust approach for large reports than relying on stdout buffers, which avoids the maxBuffer truncation risk. I've noted the verification of the Expo plugin smoke tests. Everything looks good to go.