Fix incompatibilities with pre-OAuth2 version of Server Manager - #409
Draft
isc-klu wants to merge 3 commits into
Draft
Fix incompatibilities with pre-OAuth2 version of Server Manager#409isc-klu wants to merge 3 commits into
isc-klu wants to merge 3 commits into
Conversation
isc-klu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was incompatible with older, pre-OAuth2 versions of Server Manager and the VS Code ObjectScript extension, which do not provide authorization objects or related APIs.
This bug was difficult to catch earlier for two reasons:
types/index.d.tsand older version of Server Manager intersystems-community/intersystems-servermanager#344).This PR fixes the compatibility issue, strengthens TypeScript type checking, and refines several type annotations to better reflect runtime behavior and satisfy stricter type analysis.