Customize IPM load flags used by pull event handlers#975
Open
isc-pbarton wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
==========================================
+ Coverage 49.00% 49.31% +0.31%
==========================================
Files 23 22 -1
Lines 3304 3305 +1
==========================================
+ Hits 1619 1630 +11
+ Misses 1685 1675 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
build output shows that unit tests pass. CI is still failing with unrelated xunit-viewer issue. |
isc-dchui
reviewed
Jun 11, 2026
| ) | ||
| } | ||
|
|
||
| /// Configures additional flags to be used with zpm "load" by Package Manager pull event handlers |
Collaborator
There was a problem hiding this comment.
How does this handle flags that look different, e.g. load -dev -DNoMapping=1 -extra-pip-flags "--timeout 30"?
Should also probably test that these get handled correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #974
You can now configure custom load flags to be used by the IPM event handlers. This is enough of a niche that for now I'm not adding this setting to the Configure() API or the Settings page.
Testing
Unit test class is an integration test of the PackageManagerReload event handler, covering the existing and new behavior.
Checklist
mainbranch rebased or merged.git-webui/srchave matching changes ingit-webui/release)