fix(http-signature-utils): require content-digest when request body present - #38
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
…resent Signature-Input that omitted content-digest previously validated when a body was present (fail-open), allowing the body to be swapped under an otherwise valid signature. Align with open-payments-go: if the request has a body, content-digest must be covered and verified. Also fix the regression test so it exercises the digest check without an Authorization header (the shared fixture previously failed for the wrong reason).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
When a request has a body,
validateSigInputComponentsnow requirescontent-digestto be covered by Signature-Input and verified (along with content-length / content-type). Previously, omittingcontent-digestfailed open: a Signature-Input covering only@method/@target-uri/ etc. could validate while the body was swapped.Also fixes the existing regression test titled "fails if content-digest is missing while body is present": the shared fixture always set
Authorization, so the case failed on the auth-component check rather than the digest check. The test now runs without Authorization so it actually asserts the digest requirement.Context
Sibling of interledger/open-payments-go#50 (Go already requires content-digest when a body is present). Tip verified at
a08efc2758b743abae0d6979c3c6083dd2198263.Verified locally:
pnpm testinpackages/http-signature-utils(30 passed).Test plan
pnpm testinpackages/http-signature-utilsvalidateSignature/validateSigInputComponentswith bodied requests includecontent-digestin Signature-Input (expected for Open Payments / GNAP)Made with Cursor