feat: will now also consider stanalone applications - #21
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the chartvalidator/checker tool so it can discover Helm charts not only from ArgoCD ApplicationSet manifests but also from standalone ArgoCD Application manifests, including multi-source Applications with helm.valueFiles.
Changes:
- Replace the ApplicationSet-only chart discovery flow with a unified
findCharts()that scans bothappsets/andapplications/layouts. - Add Application manifest parsing (
applications.go) to extract chart sources and translatehelm.valueFilesinto local file paths. - Update Helm rendering to accept an ordered list of values files, and add unit tests for the new discovery/parsing behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| chartvalidator/checker/types.go | Adds ValueFiles and a helper to resolve which values files should be passed to Helm. |
| chartvalidator/checker/main.go | Updates user-facing help text and switches to the new unified chart discovery function. |
| chartvalidator/checker/engine_chart_rendering.go | Builds Helm args using a dynamic list of -f value files and validates their existence. |
| chartvalidator/checker/appsets.go | Renames and expands chart discovery to support both ApplicationSets and Applications. |
| chartvalidator/checker/applications.go | New Application scanner/parser supporting single-source, multi-source, and multi-document YAML. |
| chartvalidator/checker/applications_test.go | New tests covering Application parsing, mixed-layout discovery, and resolved values-file behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+48
to
60
| func (c ChartRenderParams) resolvedValueFiles() []valueFileRef { | ||
| if len(c.ValueFiles) > 0 { | ||
| refs := make([]valueFileRef, 0, len(c.ValueFiles)) | ||
| for _, p := range c.ValueFiles { | ||
| refs = append(refs, valueFileRef{path: p, label: "values file"}) | ||
| } | ||
| return refs | ||
| } | ||
| return []valueFileRef{ | ||
| {path: c.BaseValuesFile, label: "base values file"}, | ||
| {path: c.ValuesOverride, label: "values override file"}, | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.