Snapshot/signal value format registry - #701
Open
desmonddak wants to merge 3 commits into
Open
Conversation
desmonddak
force-pushed
the
snapshot/signal-value-format-registry
branch
2 times, most recently
from
August 25, 2026 22:48
8f7edc7 to
532ca8a
Compare
mkorbel1
reviewed
Aug 25, 2026
There was a problem hiding this comment.
Pull request overview
Introduces shared signal-value formatting and occurrence-address storage, replacing draft PR #697.
Changes:
- Adds signal format conversion, preference storage, and notifications.
- Adds a generic occurrence-address trie.
- Adds tests, exports, dependencies, and README documentation.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
signal_value_format_registry.dart |
Implements formatting and preference registry. |
signal_value_format_registry_test.dart |
Tests formatting and registry lookup. |
rohd_devtools_widgets.dart |
Exports the registry API. |
rohd_devtools_widgets/pubspec.yaml |
Adds hierarchy dependency. |
rohd_devtools_widgets/README.md |
Documents shared utilities. |
occurrence_trie.dart |
Implements occurrence-address trie storage. |
occurrence_trie_test.dart |
Tests trie operations and validation. |
hierarchy_models.dart |
Exports the trie API. |
Suppressed comments (5)
rohd_devtools_extension/packages/rohd_devtools_widgets/README.md:47
ExportToastdoes not exist in the public API; this utility is exported asshowExportToast. Documenting the nonexistent type makes the usage guidance unusable.
- **`ExportToast`** — Toast notification widget for export feedback and status messages.
rohd_devtools_extension/packages/rohd_devtools_widgets/README.md:53
- There is no exported
CrossProbeMenusymbol. Cross-probe menu integration is provided by top-level helpers such asbuildGotoSourceMenuItems, so the README currently points users to an API they cannot import.
- **`CrossProbeMenu`** — Shared context menu integration for cross-probing actions across different ROHD DevTools surfaces.
rohd_devtools_extension/packages/rohd_devtools_widgets/README.md:57
LogicTypeUtilsis not declared or exported. The public entry point is the top-levelexpandLogicTypefunction (withTypeFieldNodeas its result), so this API reference is inaccurate.
- **`LogicTypeUtils`** — Utilities for working with ROHD logic types and formatting logic values for display.
rohd_devtools_extension/packages/rohd_devtools_widgets/README.md:61
BitExpansionMenuis not a public declaration. The package exportsBitExpansionMenuValuesand menu-building/resolution functions instead, so consumers cannot use the documented symbol.
- **`BitExpansionMenu`** — Shared popup menu items for "Expand Bits" and "Define Bit Fields" actions used across signal selection overlays and panels.
rohd_devtools_extension/packages/rohd_devtools_widgets/README.md:69
- No
RohdExtensionStatusdeclaration is exported. Extension status is represented byRohdModuleInfoand itsRohdFormatInfoentries, so this documentation names an unusable API.
- **`RohdExtensionStatus`** — Status information and connection state for the ROHD extension.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
desmonddak
force-pushed
the
snapshot/signal-value-format-registry
branch
from
August 25, 2026 23:09
532ca8a to
e938efd
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
desmonddak
force-pushed
the
snapshot/signal-value-format-registry
branch
from
August 25, 2026 23:15
e938efd to
5885e68
Compare
mkorbel1
reviewed
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
This is a dependency needed as central for widgets to communicate changes in the way a signal value is displayed.
It replaces PR #697 which is now a draft.
Related Issue(s)
Testing
This feature is used in future widgets where testing is performed, but not introduced yet. But basic testing for store/recall of format is performed.
Backwards-compatibility
No
Documentation
Not yet.