Skip to content

Snapshot/signal value format registry - #701

Open
desmonddak wants to merge 3 commits into
intel:mainfrom
desmonddak:snapshot/signal-value-format-registry
Open

Snapshot/signal value format registry#701
desmonddak wants to merge 3 commits into
intel:mainfrom
desmonddak:snapshot/signal-value-format-registry

Conversation

@desmonddak

Copy link
Copy Markdown
Contributor

Description & Motivation

This is a dependency needed as central for widgets to communicate changes in the way a signal value is displayed.
It replaces PR #697 which is now a draft.

Related Issue(s)

Testing

This feature is used in future widgets where testing is performed, but not introduced yet. But basic testing for store/recall of format is performed.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Not yet.

@desmonddak
desmonddak force-pushed the snapshot/signal-value-format-registry branch 2 times, most recently from 8f7edc7 to 532ca8a Compare August 25, 2026 22:48
@mkorbel1
mkorbel1 requested a balanced review from Copilot August 25, 2026 22:51

@mkorbel1 mkorbel1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Comment thread packages/rohd_hierarchy/lib/src/occurrence_trie.dart
Comment thread packages/rohd_hierarchy/lib/src/occurrence_trie.dart Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces shared signal-value formatting and occurrence-address storage, replacing draft PR #697.

Changes:

  • Adds signal format conversion, preference storage, and notifications.
  • Adds a generic occurrence-address trie.
  • Adds tests, exports, dependencies, and README documentation.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
signal_value_format_registry.dart Implements formatting and preference registry.
signal_value_format_registry_test.dart Tests formatting and registry lookup.
rohd_devtools_widgets.dart Exports the registry API.
rohd_devtools_widgets/pubspec.yaml Adds hierarchy dependency.
rohd_devtools_widgets/README.md Documents shared utilities.
occurrence_trie.dart Implements occurrence-address trie storage.
occurrence_trie_test.dart Tests trie operations and validation.
hierarchy_models.dart Exports the trie API.
Suppressed comments (5)

rohd_devtools_extension/packages/rohd_devtools_widgets/README.md:47

  • ExportToast does not exist in the public API; this utility is exported as showExportToast. Documenting the nonexistent type makes the usage guidance unusable.
- **`ExportToast`** — Toast notification widget for export feedback and status messages.

rohd_devtools_extension/packages/rohd_devtools_widgets/README.md:53

  • There is no exported CrossProbeMenu symbol. Cross-probe menu integration is provided by top-level helpers such as buildGotoSourceMenuItems, so the README currently points users to an API they cannot import.
- **`CrossProbeMenu`** — Shared context menu integration for cross-probing actions across different ROHD DevTools surfaces.

rohd_devtools_extension/packages/rohd_devtools_widgets/README.md:57

  • LogicTypeUtils is not declared or exported. The public entry point is the top-level expandLogicType function (with TypeFieldNode as its result), so this API reference is inaccurate.
- **`LogicTypeUtils`** — Utilities for working with ROHD logic types and formatting logic values for display.

rohd_devtools_extension/packages/rohd_devtools_widgets/README.md:61

  • BitExpansionMenu is not a public declaration. The package exports BitExpansionMenuValues and menu-building/resolution functions instead, so consumers cannot use the documented symbol.
- **`BitExpansionMenu`** — Shared popup menu items for "Expand Bits" and "Define Bit Fields" actions used across signal selection overlays and panels.

rohd_devtools_extension/packages/rohd_devtools_widgets/README.md:69

  • No RohdExtensionStatus declaration is exported. Extension status is represented by RohdModuleInfo and its RohdFormatInfo entries, so this documentation names an unusable API.
- **`RohdExtensionStatus`** — Status information and connection state for the ROHD extension.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/rohd_hierarchy/lib/src/occurrence_trie.dart Outdated
Comment thread rohd_devtools_extension/packages/rohd_devtools_widgets/README.md Outdated
@desmonddak
desmonddak force-pushed the snapshot/signal-value-format-registry branch from 532ca8a to e938efd Compare August 25, 2026 23:09
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@desmonddak
desmonddak force-pushed the snapshot/signal-value-format-registry branch from e938efd to 5885e68 Compare August 25, 2026 23:15
@mkorbel1
mkorbel1 requested a balanced review from Copilot August 26, 2026 16:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Comment thread packages/rohd_hierarchy/lib/src/occurrence_trie.dart Outdated
@desmonddak
desmonddak requested a review from mkorbel1 August 26, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants