[SYCL] Fix -Wmain error in dpllvm.cpp#22623
Merged
Merged
Conversation
reinterpret_cast<void *>(main) is a Clang extension warning (-Wmain) that becomes an error under -Werror. Use the address of a local anchor function instead, matching the idiom already used in clang/tools/driver/driver.cpp and llvm/tools/llvm-config/llvm-config.cpp. Fixes a regression from 328217f. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
dm-vodopyanov
approved these changes
Jul 14, 2026
Fznamznon
reviewed
Jul 14, 2026
Fznamznon
left a comment
Contributor
There was a problem hiding this comment.
Why don't we do it the same way as llvm tools, instead of adding an empty function, do
/// Compute the path to the main executable.
static std::string getExecutablePath(const char *Argv0) {
// This just needs to be some symbol in the binary; C++ doesn't
// allow taking the address of ::main however.
void *P = (void *)(intptr_t)getExecutablePath;
return sys::fs::getMainExecutable(Argv0, P);
}
Contributor
Author
this file only has one function: main |
Contributor
Author
done, thanks |
Fznamznon
approved these changes
Jul 15, 2026
Contributor
Author
|
@intel/llvm-gatekeepers please merge, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reinterpret_cast<void *>(main) is a Clang extension warning (-Wmain) that becomes an error under -Werror. Use the same idom in llvm/tools/llvm-config/llvm-config.cpp.
Fixes a regression from 328217f.