[SYCL][DOC] New device aspect: ext_oneapi_per_event_profiling#22595
Open
slawekptak wants to merge 1 commit into
Open
[SYCL][DOC] New device aspect: ext_oneapi_per_event_profiling#22595slawekptak wants to merge 1 commit into
slawekptak wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the proposed sycl_ext_oneapi_reusable_events extension documentation to replace a platform info descriptor with a device aspect for advertising per-event profiling support.
Changes:
- Replaces the
event_profilingplatform info descriptor withaspect::ext_oneapi_per_event_profiling. - Updates the documented error/feature-availability conditions to be based on device aspects (including “all devices in a context” for
make_event(ctxt, ...)). - Updates the examples and backend mapping notes to use the new aspect-based capability check.
Comment on lines
139
to
+141
| `PropertyListT` contains an `enable_profiling` property that enables profiling | ||
| timestamps and if the platform containing `ctxt` does not support creation of | ||
| such events as reported by the `event_profiling` information descriptor. | ||
| timestamps and if not all devices in `ctxt` have | ||
| `aspect::ext_oneapi_per_event_profiling`. |
| for (sycl::device dev : ctxt.get_devices()) { | ||
| if (!dev.has(sycl::aspect::ext_oneapi_per_event_profiling)) { | ||
| std::cout << "Cannot time kernels without per-event profiling support\n"; | ||
| return; |
Replace the platform descriptor with a new device aspect, to indicate if a device supports per-event profiling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the platform descriptor with a new device aspect, to indicate if a device supports per-event profiling.