[AMDGPU] fix Coverity issues#22060
Conversation
There was a problem hiding this comment.
Should these changes go upstream?
YuriPlyakhin
left a comment
YuriPlyakhin
left a comment
There was a problem hiding this comment.
we should not modify AMDGPU target code downstream. If this a real problem, it should go upstream.
|
@sarnex @YuriPlyakhin I understand and agree with you but this is per Pallavi / Thorsten / Ashbaugh request. Here is the upstream PR: llvm/llvm-project#198570 |
@bratpiorka , what was exactly the request? Maybe we should discuss in a call... |
bratpiorka
force-pushed
the
rrudnick_coverity_x
branch
from
be35300 to
bbc0b4f
Compare
|
@sarnex @YuriPlyakhin upstream PR llvm/llvm-project#198570 was merged |
|
Hi @sarnex @YuriPlyakhin - my upstream PR is merged. Are you okay with merging this one (even if it causes some extra work during the next pulldown)? |
|
Is this patch the exact same as upstream? If not please cherry pick it in this PR. Then it will be fine. |
YuriPlyakhin
left a comment
YuriPlyakhin
left a comment
There was a problem hiding this comment.
The patch is different from community, because in community this code changed: llvm/llvm-project@1b927cf
can we get community changes pulled down?
I'd like to avoid any divergence in non-tested code in this repo.
3 participants
fix Coverity issues 3493587 and 3498634
upstream PR: llvm/llvm-project#198570