[SYCL][test] Add --no-offloadlib and fno-sycl-instrument-device-code to spir/spirv target RUN lines in clang-linker-wrapper test

[srividya-sundaram]

After PR #21672, SYCL device libraries are linked at compile time when using --offload-new-driver with SPIR/SPIRV targets. The compile RUN lines in clang-linker-wrapper.cpp that use SPIR-based targets now require the device libraries to be resolvable on disk.

In environments where the device libraries are not installed alongside the compiler (e.g. MSan self builds), these RUN lines fail with "cannot find expected SYCL device library" errors.

Fix by adding --sysroot=%S/Inputs/SYCL to the affected compile RUN lines so the stub .bc files in the test inputs directory are used for path resolution. This is sufficient since these are driver tests that check command line arguments, not actual compilation output.

[srividya-sundaram]

Test failures in pre-commit testing are unrelated to this PR.

[mdtoguchi]

Can you update to head? My previous PR that updated this test added the REQUIRES: libdevice to the top of the file. With these --sysroot changes, the libdevice requirement shouldn't be needed anymore.

[mdtoguchi]

Can you update to head? My previous PR that updated this test added the REQUIRES: libdevice to the top of the file. With these --sysroot changes, the libdevice requirement shouldn't be needed anymore.

Nevermind - this won't work. Due to the stub .bc files being empty, the linking from within the device compilation step will fail:
.---command stderr------------
| fatal error: cannot open file '/localdisk2/mtoguchi/github/llvm/clang/test/Driver/Inputs/SYCL/lib/libsycl-crt.bc': file too small to contain bitcode header
| 1 error generated.
`-----------------------------
error: command failed with exit status: 1

[srividya-sundaram]

Can you update to head? My previous PR that updated this test added the REQUIRES: libdevice to the top of the file. With these --sysroot changes, the libdevice requirement shouldn't be needed anymore.

Nevermind - this won't work. Due to the stub .bc files being empty, the linking from within the device compilation step will fail: .---command stderr------------ | fatal error: cannot open file '/localdisk2/mtoguchi/github/llvm/clang/test/Driver/Inputs/SYCL/lib/libsycl-crt.bc': file too small to contain bitcode header | 1 error generated. `----------------------------- error: command failed with exit status: 1

@mdtoguchi Are there any other changes needed for this PR?

[mdtoguchi]

Can you update to head? My previous PR that updated this test added the REQUIRES: libdevice to the top of the file. With these --sysroot changes, the libdevice requirement shouldn't be needed anymore.

Nevermind - this won't work. Due to the stub .bc files being empty, the linking from within the device compilation step will fail: .---command stderr------------ | fatal error: cannot open file '/localdisk2/mtoguchi/github/llvm/clang/test/Driver/Inputs/SYCL/lib/libsycl-crt.bc': file too small to contain bitcode header | 1 error generated. `----------------------------- error: command failed with exit status: 1

@mdtoguchi Are there any other changes needed for this PR?

No - this can be abandoned.

[jinge90]

Hi, @mdtoguchi and @srividya-sundaram
A suggestion to solve "'/localdisk2/mtoguchi/github/llvm/clang/test/Driver/Inputs/SYCL/lib/libsycl-crt.bc': file too small to contain bitcode header | 1 error generated. `----------------------------- error: command failed with exit status: 1":
Use --no-offloadlib in cflags instead of "--sysroot=XXX". Some tests will build and generate binary, compiler will try to parse devicelib modules if '--no-offloadlib' is not added. By adding "--no-offloadlib", devicelibs will not be invovled, so this error will be gone.

Thanks very much.

[jinge90]

Hi, @mdtoguchi and @srividya-sundaram A suggestion to solve "'/localdisk2/mtoguchi/github/llvm/clang/test/Driver/Inputs/SYCL/lib/libsycl-crt.bc': file too small to contain bitcode header | 1 error generated. `----------------------------- error: command failed with exit status: 1": Use --no-offloadlib in cflags instead of "--sysroot=XXX". Some tests will build and generate binary, compiler will try to parse devicelib modules if '--no-offloadlib' is not added. By adding "--no-offloadlib", devicelibs will not be invovled, so this error will be gone.

Thanks very much.

I missed itt libraries, it is not controlled by '--no-offloadlib', we need '--no-offloadlib -fno-sycl-instrument-device-code' to get rid of all dependencies on libdevice files.

[jinge90]

Hi, @mdtoguchi and @srividya-sundaram
I updated this PR to get rid of all devicelib files, could you help review it?
Thanks very much.

[jinge90]

Hi, @intel/llvm-gatekeepers
Could you help merge?
Thanks very much.