Skip to content

feat: Refactor external groups data source#3549

Open
stevehipwell wants to merge 1 commit into
mainfrom
stevehipwell/refactor-external-groups-data-source
Open

feat: Refactor external groups data source#3549
stevehipwell wants to merge 1 commit into
mainfrom
stevehipwell/refactor-external-groups-data-source

Conversation

@stevehipwell

@stevehipwell stevehipwell commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Related to #3537


Before the change?

  • github_external_group data source didn't use max per page resulting in a slow query time
  • github_external_group didn't support filtering results
  • github_external_group had no tests

After the change?

  • github_external_group has been refactored to the latest patterns
    • Use max per page
    • Add display_name_filter to filter returned groups
    • Updated documentation
    • Acceptance tests

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell stevehipwell added this to the v6.14.0 milestone Jul 17, 2026
@stevehipwell
stevehipwell requested a review from deiga July 17, 2026 14:21
@stevehipwell stevehipwell self-assigned this Jul 17, 2026
@stevehipwell stevehipwell added Type: Feature New feature or request Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Jul 17, 2026
@github-actions

Copy link
Copy Markdown

👋 Hi, and thank you for this contribution!

This repo is maintained by GitHub and community members on a best-effort basis. We'll get to this as soon as we can.

You can help us prioritize by joining the discussion on open issues and PRs, sharing details on the changes you need, and reviewing other contributions.


🤖 This is an automated message.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New feature or request Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants