fix: add DatabaseID to parent team GraphQL query to eliminate N+1 REST calls#3384
Open
yoshi-taka wants to merge 1 commit into
Open
fix: add DatabaseID to parent team GraphQL query to eliminate N+1 REST calls#3384yoshi-taka wants to merge 1 commit into
yoshi-taka wants to merge 1 commit into
Conversation
…T calls PR integrations#1452 added the parent object to the teams data source, but parent.id was populated from the GraphQL node ID instead of the numeric database ID, causing issue integrations#2491. PR integrations#2507 worked around this by adding parent_team_id and parent_team_slug, using a REST GetTeamBySlug call per parent team. This commit fixes the root cause by adding DatabaseID to the parent team GraphQL query and using it for parent.id. This makes the per-team REST call unnecessary and removes the N+1 pattern.
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1452 added the parent object to the teams data source, but
parent.idwas populated from the GraphQL node ID instead of the numeric database ID, causing issue #2491.PR #2507 worked around this by adding
parent_team_idandparent_team_slug, using a RESTGetTeamBySlugcall per parent team.This commit fixes the root cause by adding
DatabaseIDto the parent team GraphQL query and using it forparent.id. This makes the per-team REST call unnecessary and removes the N+1 pattern.Resolves #2491
Before the change?
parent.idwas populated from the GraphQL node ID instead of the numeric database ID.GetTeamBySlugcall per parent team to obtain the numeric parent team ID.After the change?
DatabaseIDis included in the parent team GraphQL query.parent.idis populated from the numeric database ID.GetTeamBySlugcall is no longer needed.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!