fix(ui-modal): add whitespace between text nodes in Modal body aria-label #2639
Open
git-nandor wants to merge 1 commit into
Open
fix(ui-modal): add whitespace between text nodes in Modal body aria-label #2639git-nandor wants to merge 1 commit into
git-nandor wants to merge 1 commit into
Conversation
|
Visual regression report✅ No changes.
Baselines come from the |
ToMESSKa
requested changes
Jul 15, 2026
Contributor
Author
|
Thanks, fixed! |
…y aria-label The Modal body's scroll aria-label is assembled from the header's text nodes, which were concatenated with no separator. When the header contains a Heading with `aiVariant` (which renders a decorative "IgniteAI" text node before the title), this produced malformed labels like "IgniteAIAI Nutrition Facts" that VoiceOver announced incorrectly (WCAG 1.3.1). Trim each text node and join non-empty ones with a single space so adjacent text nodes from different elements are separated. Applies to the v2 ModalHeader. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
git-nandor
force-pushed
the
INSTUI-5096_modal_body_aria-label_omits_whitespace
branch
from
July 17, 2026 07:49
13ed61b to
0236c2a
Compare
ToMESSKa
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-5096
Problem
ModalHeader derives its
aria-labelby walking every text node in the header and concatenating them —with no separator between producing malformed labels such as:
"IgniteAINutrition Facts""IgniteAIData Permission Levels"VoiceOver announced these incorrectly. This violates WCAG 1.3.1 Info and Relationships (Level A).
Fix
Trim each harvested text node, drop empty ones, and join the rest with a single space.
Test plan
Permission Levels dialogs and confirm the body region announces correctly
"IgniteAI Nutrition Facts"(not"IgniteAINutr...")🤖 Generated with Claude Code