feat: Add native kafka-python library support. - #894
Open
CagriYonca wants to merge 1 commit into
Open
Conversation
CagriYonca
force-pushed
the
kafka-update
branch
from
August 24, 2026 15:39
6c41428 to
226d71a
Compare
Signed-off-by: Cagri Yonca <cagri@ibm.com>
CagriYonca
force-pushed
the
kafka-update
branch
from
August 25, 2026 09:14
226d71a to
a90fa01
Compare
pvital
requested changes
Aug 25, 2026
| - pykafka: | ||
| matrix: | ||
| parameters: | ||
| py-version: ["3.9", "3.12", "3.13"] |
Member
There was a problem hiding this comment.
I would suggest changing 3.13 to the latest stable version, 3.14.
Suggested change
| py-version: ["3.9", "3.12", "3.13"] | |
| py-version: ["3.9", "3.12", "3.14"] |
| confluent-kafka>=2.0.0 | ||
| kafka-python>=2.0.0; python_version < "3.12" | ||
| kafka-python-ng>=2.0.0; python_version >= "3.12" | ||
| kafka-python>=2.0.3 |
Member
There was a problem hiding this comment.
Let's keep the previous lower-bound version; remove the conditional and the kafka-python-ng line.
Suggested change
| kafka-python>=2.0.3 | |
| kafka-python>=2.0.0 |
| gevent>=23.9.0.post1 | ||
| confluent-kafka>=2.0.0 | ||
| kafka-python-ng>=2.0.0 | ||
| kafka-python>=2.0.3 |
Member
There was a problem hiding this comment.
Suggested change
| kafka-python>=2.0.3 | |
| kafka-python>=2.0.0 |
Member
There was a problem hiding this comment.
I was thinking whether it wouldn't be better to remove the KAFKA_TEST environment variable and make all Kafka tests part of the default pipeline. WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.