Skip to content

fix: Add support for custom span filtering#859

Open
CagriYonca wants to merge 1 commit intomainfrom
fix/custom-span-filtering
Open

fix: Add support for custom span filtering#859
CagriYonca wants to merge 1 commit intomainfrom
fix/custom-span-filtering

Conversation

@CagriYonca
Copy link
Copy Markdown
Contributor

No description provided.

@CagriYonca CagriYonca self-assigned this Apr 1, 2026
@CagriYonca CagriYonca requested a review from a team as a code owner April 1, 2026 14:10
@CagriYonca CagriYonca force-pushed the fix/custom-span-filtering branch 4 times, most recently from cc66ec4 to 27614a7 Compare April 1, 2026 15:02
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request.

Comment thread src/instana/util/span_utils.py Outdated
@CagriYonca CagriYonca force-pushed the fix/custom-span-filtering branch 2 times, most recently from 2ee3887 to 1924c28 Compare April 13, 2026 09:22
@CagriYonca CagriYonca requested a review from pvital April 13, 2026 09:23
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On top of the following requests, I saw your PR introduces two new maintainability issues reported by SonaQube. Please, fix them.

Comment thread src/instana/util/span_utils.py Outdated
Comment thread src/instana/util/span_utils.py Outdated
@CagriYonca CagriYonca force-pushed the fix/custom-span-filtering branch from 1924c28 to d256e9f Compare April 14, 2026 09:22
@CagriYonca CagriYonca requested a review from pvital April 14, 2026 11:26
@GSVarsha
Copy link
Copy Markdown
Contributor

Verified the changes on scenarios 2 and 4 as described here.

What is verified?

When Instana Python SDK is in charge of the tracer and requests instrumentation from OTel instrumentation is also active, we don't see internal calls to the agent such as POST http://localhost:42699/com.instana.plugin.python.87417recorded! 🎉

Signed-off-by: Cagri Yonca <cagri@ibm.com>
@CagriYonca CagriYonca force-pushed the fix/custom-span-filtering branch from d256e9f to 133be63 Compare April 21, 2026 08:42
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants