Fix mobile nav scroll lock left stranded on resize to desktop#384
Merged
Conversation
* fix(docs): release mobile nav scroll lock on resize The marketing site mobile nav locked body scroll on open and only released it when the menu closed via a state change. Widening the window past the md breakpoint hid the menu via CSS without closing it, so the scroll lock was stranded and the desktop page became unscrollable. Rebuild the menu on the shadcn Sheet (Radix Dialog), which owns the focus trap, Escape handling, and body scroll lock and releases all three on close. Add a matchMedia listener that closes the sheet when crossing into desktop width. Present it as a bottom drawer with an icon and label on every row and a content-aligned close button. * fix(docs): contain overscroll on mobile nav drawer Add overscroll-contain to the Sheet drawer's scroll container so touch overscroll can't chain to the locked body when the nav exceeds the viewport. GitOrigin-RevId: 84403240c4b3c0e71565cb6e889c47e5e8e9d110
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/u/123133689?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28412077393). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.