Skip to content

fix(agents-core): fix subagent stepCountIs inheritance and project skills cleanup - #3502

Open
Adityakk9031 wants to merge 1 commit into
inkeep:mainfrom
Adityakk9031:fix/agent-full-step-count-inheritance
Open

fix(agents-core): fix subagent stepCountIs inheritance and project skills cleanup#3502
Adityakk9031 wants to merge 1 commit into
inkeep:mainfrom
Adityakk9031:fix/agent-full-step-count-inheritance

Conversation

@Adityakk9031

Copy link
Copy Markdown

Summary

This PR fixes two critical data-access issues in @inkeep/agents-core:

  1. Subagent \stepCountIs\ Inheritance: In \�pplyExecutionLimitsInheritance\ (\�gentFull.ts), \projectStopWhen.stepCountIs\ was incorrectly mutating the parent \�gentData.stopWhen\ instead of the sub-agent's \subAgentData.stopWhen, and required an unnecessary \canTransferTo\ condition. Fixed to properly propagate \stepCountIs\ onto each \subAgentData.stopWhen.
  2. Orphaned Skills Cleanup: In \updateFullProjectServerSide\ (\projectFull.ts), while orphaned tools, functions, external agents, components, and agents were cleaned up during full project updates, skills were omitted. Added orphaned skill detection and cleanup with \deleteSkill.

Verification

  • \pnpm --filter @inkeep/agents-core test src/tests/data-access/agentFull.test.ts src/tests/data-access/projectFull.test.ts\ passes (35/35 tests pass).
  • \pnpm --filter @inkeep/agents-core typecheck\ passes with zero errors.

@changeset-bot

changeset-bot Bot commented Aug 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c8593b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@inkeep/agents-core Patch
@inkeep/agents-work-apps Patch
@inkeep/ai-sdk-provider Patch
@inkeep/create-agents Patch
@inkeep/agents-api Patch
@inkeep/agents-manage-ui Patch
@inkeep/agents-cli Patch
@inkeep/agents-email Patch
@inkeep/agents-mcp Patch
@inkeep/agents-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

What happens next:

  • A maintainer will review your PR.
  • If you don't hear back within a few business days, please comment here to nudge our team.
  • This repository is maintained through an internal mirror. When your change is accepted, this PR will close automatically. Don't be alarmed when it closes — that's how it merges, and your authorship is preserved.

@Adityakk9031

Copy link
Copy Markdown
Author

@mike-inkeep have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant