fix(lockfiles) detect v1 lockfiles and shrinkwraps without lockfileVersion#27
Merged
fix(lockfiles) detect v1 lockfiles and shrinkwraps without lockfileVersion#27
Conversation
…rsion v1 lockfiles and npm-shrinkwrap.json files often omit the lockfileVersion field entirely. tryParseNpm required typeof lockfileVersion === 'number', so these files failed content-based detection. The parser (fromPackageLock) already handled them via the fromDependenciesTree fallback — only routing in detectType was broken. The new heuristic checks for a dependencies tree with object values (which distinguishes lockfiles from package.json where values are version-range strings). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tryParseNpminsrc/detect.jsnow recognizes v1 lockfiles and shrinkwrap files that omit thelockfileVersionfield. WhenlockfileVersionis absent, a fallback heuristic checks for adependenciestree with object values — distinguishing lockfiles frompackage.jsonwhere dependency values are version-range strings.Why
tryParseNpmrequiredtypeof parsed.lockfileVersion === 'number', so v1 files withoutlockfileVersionfailed content-based detection and threw "Unable to detect lockfile type." ThefromPackageLockparser already handled these files correctly via thefromDependenciesTreefallback — only routing indetectTypewas broken.Risk Assessment
Low risk: The new heuristic only activates when
lockfileVersionis absent. All existing detection paths (v1 withlockfileVersion, v2, v3) are unchanged. A guard test confirmspackage.jsonfiles are not misidentified. 469 tests pass.References