Fix: Add null check for num_features parameter in BatchNorm1D#161
Open
prjanitor wants to merge 1 commit intoimdeepmind:mainfrom
Open
Fix: Add null check for num_features parameter in BatchNorm1D#161prjanitor wants to merge 1 commit intoimdeepmind:mainfrom
prjanitor wants to merge 1 commit intoimdeepmind:mainfrom
Conversation
The num_features parameter is required by PyTorch's BatchNorm1d but was defaulting to None. Added a null check to ensure num_features is provided before instantiation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
The
num_featuresparameter inBatchNorm1Ddefaults toNone, which causes PyTorch'sBatchNorm1dto raise an error when instantiated without this required parameter.Root Cause
The validation logic only checked if
num_featureswas an integer when it was not None:This allowed
num_features=Noneto pass validation, but PyTorch requires this parameter.Fix
Changed the validation to also check for
None:Testing
Users will now receive a clear error message when attempting to create a
BatchNorm1Dlayer without specifyingnum_features.This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.