Fix/fr localization assets - #3603
Open
kaizencode-art wants to merge 2 commits into
Open
Conversation
PR SummaryFixed/fr localization assets: added missing diagrams, corrected folder names, and switched image links to local paths to align with upstream pattern directories. No translated prose was modified. Also updated folder names: Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (2)
Files Processed (24)
- localization/fr/abstract-document/README.md (1 hunk)
- localization/fr/abstract-document/etc/abstract-document.png (0 hunks)
- localization/fr/abstract-factory/README.md (1 hunk)
- localization/fr/abstract-factory/etc/abstract-factory.urm.png (0 hunks)
- localization/fr/active-object/README.md (1 hunk)
- localization/fr/active-object/etc/active-object.urm.png (0 hunks)
- localization/fr/acyclic-visitor/README.md (from localization/fr/acyclic-visitore/README.md) (1 hunk)
- localization/fr/acyclic-visitor/etc/acyclic-visitor.png (0 hunks)
- localization/fr/adapter/README.md (1 hunk)
- localization/fr/adapter/etc/adapter.urm.png (0 hunks)
- localization/fr/ambassador/README.md (1 hunk)
- localization/fr/ambassador/etc/ambassador.urm.png (0 hunks)
- localization/fr/async-method-invocation/README.md (1 hunk)
- localization/fr/async-method-invocation/etc/async-method-invocation.png (0 hunks)
- localization/fr/balking/README.md (1 hunk)
- localization/fr/balking/etc/balking.png (0 hunks)
- localization/fr/bridge/README.md (1 hunk)
- localization/fr/bridge/etc/bridge.urm.png (0 hunks)
- localization/fr/builder/etc/builder.urm.png (0 hunks)
- localization/fr/business-delegate/etc/business-delegate.urm.png (0 hunks)
- localization/fr/microservices-aggregrator/README.md (from localization/fr/aggregator-microservices/README.md) (1 hunk)
- localization/fr/microservices-aggregrator/aggregator-service/etc/aggregator-service.png (0 hunks)
- localization/fr/microservices-api-gateway/README.md (from localization/fr/api-gateway/README.md) (1 hunk)
- localization/fr/microservices-api-gateway/etc/api-gateway.png (0 hunks)
Actionable Comments (0)
Skipped Comments (11)
-
localization/fr/abstract-document/README.md [171-171]
readability: "Use local asset path for diagram"
-
localization/fr/abstract-factory/README.md [179-179]
readability: "Local asset path for Abstract Factory diagram"
-
localization/fr/active-object/README.md [124-124]
readability: "Active Object diagram asset path"
-
localization/fr/acyclic-visitor/README.md [125-125]
maintainability: "Acyclic Visitor diagram path after rename"
-
localization/fr/adapter/README.md [95-95]
readability: "Adapter diagram local asset path"
-
localization/fr/ambassador/README.md [175-175]
readability: "Ambassador diagram asset path"
-
localization/fr/async-method-invocation/README.md [151-151]
readability: "Async Method Invocation diagram path"
-
localization/fr/balking/README.md [117-117]
readability: "Balking diagram path"
-
localization/fr/bridge/README.md [197-197]
readability: "Bridge diagram asset path"
-
localization/fr/microservices-aggregrator/README.md [96-96]
readability: "Aggregator Microservice diagram path"
-
localization/fr/microservices-api-gateway/README.md [145-145]
readability: "API Gateway diagram path"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3603 +/- ##
============================================
+ Coverage 83.79% 83.80% +0.01%
- Complexity 4277 4279 +2
============================================
Files 1121 1121
Lines 15144 15144
Branches 723 723
============================================
+ Hits 12690 12692 +2
+ Misses 2159 2157 -2
Partials 295 295 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The French localization is missing its
etc/images and uses repository-relative image links that break when published.This adds the 13 missing diagrams, makes the links local, fixes the misspelled
acyclic-visitorefolder, and renamesaggregator-microservicesandapi-gatewayto match the current pattern directories.No translated prose is modified; only image paths change.
Context: iluwatar/java-design-patterns-vuepress-web#119.