docs(revdep): Add reprexes for bootcluster, checked, htna and SEMdeep - #2841
Draft
krlmlr wants to merge 1 commit into
Draft
docs(revdep): Add reprexes for bootcluster, checked, htna and SEMdeep#2841krlmlr wants to merge 1 commit into
krlmlr wants to merge 1 commit into
Conversation
The four packages `revdep2` run 31048405399 flagged that the committed `revdep/` report does not. Each gets the two files this directory uses -- a runnable script and the reprex output -- and they turn out to be four different stories: * **bootcluster** calls `sample_degseq(method = "simple.no.multiple")` from `scheme2.exp()`. Defunct since 2.1.0, same as qgraph and degreenet. Still errors on 2.3.3.9029. CRAN lists no URL or BugReports for it, so it is an email to the maintainer. * **checked** passes `mode` positionally to `neighbors()`. That is soft-deprecated for 3.0.0 and only warns -- but the package's tests are snapshot tests, so 315 warnings become one failure. A one-word fix upstream. * **htna** cascades through `tna:::as.igraph.matrix()`, whose call to `graph_from_adjacency_matrix()` ends in a trailing comma. That empty argument used to reach the migration handler and error; it does not any more, so the reproducer passes and is kept as a regression test rather than sent anywhere. * **SEMdeep** fails inside `SEMgraph::SEMrun()` with a subscript out of bounds and no igraph function on the backtrace -- a silent result change, the same shape as SEMgraph's own open item. It is the one example here that is neither reduced nor rendered: SEMgraph needs Bioconductor packages that do not install where the others were rendered, so its `.md` carries the check log and a list of what to compare instead. Rendered with reprex against a locally built igraph 2.3.3.9029, so the outputs are what the current development version actually does. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DdNk5vJPSUidKGdnAYt7Dv
krlmlr
marked this pull request as draft
August 16, 2026 06:11
Contributor
Author
|
Fold into #2646. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four packages
revdep2run 31048405399 flagged that the committedrevdep/report does not. Each gets the two files this directory uses -- a runnable script and the reprex output -- and they turn out to be four different stories:sample_degseq(method = "simple.no.multiple")fromscheme2.exp(). Defunct since 2.1.0, same as qgraph and degreenet. Still errors on 2.3.3.9029. CRAN lists no URL or BugReports for it, so it is an email to the maintainer.modepositionally toneighbors(). That is soft-deprecated for 3.0.0 and only warns -- but the package's tests are snapshot tests, so 315 warnings become one failure. A one-word fix upstream.tna:::as.igraph.matrix(), whose call tograph_from_adjacency_matrix()ends in a trailing comma. That empty argument used to reach the migration handler and error; it does not any more, so the reproducer passes and is kept as a regression test rather than sent anywhere.SEMgraph::SEMrun()with a subscript out of bounds and no igraph function on the backtrace -- a silent result change, the same shape as SEMgraph's own open item. It is the one example here that is neither reduced nor rendered: SEMgraph needs Bioconductor packages that do not install where the others were rendered, so its.mdcarries the check log and a list of what to compare instead.Rendered with reprex against a locally built igraph 2.3.3.9029, so the outputs are what the current development version actually does.
Claude-Session: https://claude.ai/code/session_01DdNk5vJPSUidKGdnAYt7Dv