Skip to content

fix(migrations): ignore empty argument slots in ... #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krlmlr wants to merge 2 commits into from
Closed

fix(migrations): ignore empty argument slots in ... #2810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
860b150
fix(migrations): ignore empty argument slots in `...` (#2646)
schochastics Aug 5, 2026
9bc2614
refactor(migrations): collect `...` with `pairlist2()`, keep one gate
claude Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions R/adjacency.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ graph_from_adjacency_matrix <- function(
"graph_from_adjacency_matrix"
)
.arg_handle <- migrate_recover_args(
list(...),
rlang::pairlist2(...),
current = list(
mode = mode,
weighted = weighted,
Expand Down Expand Up @@ -339,12 +339,14 @@ graph_from_adjacency_matrix <- function(
head_args = c("adjmatrix"),
fn_name = "graph_from_adjacency_matrix"
)
list2env(.arg_handle$values, environment())
lifecycle::deprecate_soft(
"3.0.0",
what = I(.arg_handle$what),
details = .arg_handle$details
)
if (!is.null(.arg_handle)) {
list2env(.arg_handle$values, environment())
lifecycle::deprecate_soft(
"3.0.0",
what = I(.arg_handle$what),
details = .arg_handle$details
)
}
}
# END GENERATED ARG_HANDLE

Expand Down Expand Up @@ -467,7 +469,7 @@ from_adjacency <- function(
"from_adjacency"
)
.arg_handle <- migrate_recover_args(
list(...),
rlang::pairlist2(...),
current = list(
mode = mode,
weighted = weighted,
Expand Down Expand Up @@ -507,12 +509,14 @@ from_adjacency <- function(
head_args = c("adjmatrix"),
fn_name = "from_adjacency"
)
list2env(.arg_handle$values, environment())
lifecycle::deprecate_soft(
"3.0.0",
what = I(.arg_handle$what),
details = .arg_handle$details
)
if (!is.null(.arg_handle)) {
list2env(.arg_handle$values, environment())
lifecycle::deprecate_soft(
"3.0.0",
what = I(.arg_handle$what),
details = .arg_handle$details
)
}
}
# END GENERATED ARG_HANDLE

Expand Down
32 changes: 18 additions & 14 deletions R/assortativity.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ assortativity_nominal <- function(
# BEGIN GENERATED ARG_HANDLE: assortativity_nominal, do not edit, see tools/generate-migrations.R
if (...length() > 0L) {
.arg_handle <- migrate_recover_args(
list(...),
rlang::pairlist2(...),
current = list(directed = directed, normalized = normalized),
recover_new = c("directed", "normalized"),
recover_old = c("directed", "normalized"),
Expand All @@ -261,12 +261,14 @@ assortativity_nominal <- function(
head_args = c("graph", "types"),
fn_name = "assortativity_nominal"
)
list2env(.arg_handle$values, environment())
lifecycle::deprecate_soft(
"3.0.0",
what = I(.arg_handle$what),
details = .arg_handle$details
)
if (!is.null(.arg_handle)) {
list2env(.arg_handle$values, environment())
lifecycle::deprecate_soft(
"3.0.0",
what = I(.arg_handle$what),
details = .arg_handle$details
)
}
}
# END GENERATED ARG_HANDLE

Expand Down Expand Up @@ -294,7 +296,7 @@ assortativity_degree <- function(
# BEGIN GENERATED ARG_HANDLE: assortativity_degree, do not edit, see tools/generate-migrations.R
if (...length() > 0L) {
.arg_handle <- migrate_recover_args(
list(...),
rlang::pairlist2(...),
current = list(directed = directed),
recover_new = c("directed"),
recover_old = c("directed"),
Expand All @@ -304,12 +306,14 @@ assortativity_degree <- function(
head_args = c("graph"),
fn_name = "assortativity_degree"
)
list2env(.arg_handle$values, environment())
lifecycle::deprecate_soft(
"3.0.0",
what = I(.arg_handle$what),
details = .arg_handle$details
)
if (!is.null(.arg_handle)) {
list2env(.arg_handle$values, environment())
lifecycle::deprecate_soft(
"3.0.0",
what = I(.arg_handle$what),
details = .arg_handle$details
)
}
}
# END GENERATED ARG_HANDLE

Expand Down
16 changes: 9 additions & 7 deletions R/bipartite.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ bipartite_projection <- function(
# BEGIN GENERATED ARG_HANDLE: bipartite_projection, do not edit, see tools/generate-migrations.R
if (...length() > 0L) {
.arg_handle <- migrate_recover_args(
list(...),
rlang::pairlist2(...),
current = list(
multiplicity = multiplicity,
probe1 = probe1,
Expand All @@ -192,12 +192,14 @@ bipartite_projection <- function(
head_args = c("graph", "types"),
fn_name = "bipartite_projection"
)
list2env(.arg_handle$values, environment())
lifecycle::deprecate_soft(
"3.0.0",
what = I(.arg_handle$what),
details = .arg_handle$details
)
if (!is.null(.arg_handle)) {
list2env(.arg_handle$values, environment())
lifecycle::deprecate_soft(
"3.0.0",
what = I(.arg_handle$what),
details = .arg_handle$details
)
}
}
# END GENERATED ARG_HANDLE

Expand Down
Loading
Loading