Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
data #529
Changes from all commits
6bb612cfd151e5File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: ignatandrei/RSCG_Examples
Length of output: 163
🏁 Script executed:
Repository: ignatandrei/RSCG_Examples
Length of output: 1074
Add the missing DALDB image asset.
images/ReflectionIT.DisposeGenerator/csFiles/DALDB.cs.pngdoes not exist. Add the image at this exact path or updatesrcto an existing published asset.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add the HTML doctype.
Add
<!doctype html>before the first element to prevent quirks-mode rendering for this HTML page.Proposed fix
📝 Committable suggestion
🧰 Tools
🪛 HTMLHint (1.9.2)
[error] 2-2: Doctype must be declared before any non-comment content.
(doctype-first)
🤖 Prompt for AI Agents
Source: Linters/SAST tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Escape the
>character in the modified heading.Line 20 contains the literal
=>. HTMLHint reports this as an unescaped special character. Replace it with=>, or remove the arrow, so the HTML check passes.🧰 Tools
🪛 HTMLHint (1.9.2)
[error] 20-20: Special characters must be escaped : [ > ].
(spec-char-escape)
🤖 Prompt for AI Agents
Source: Linters/SAST tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Replace the placeholder description.
Line 1680 stores the literal
Package Description. This text will appear as theserdedescription in the catalog. Populate it with the actual package description before publishing.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: ignatandrei/RSCG_Examples
Length of output: 2158
🏁 Script executed:
Repository: ignatandrei/RSCG_Examples
Length of output: 738
🌐 Web query:
CodeTour VS Code tour JSON pattern field matching semantics💡 Result:
In CodeTour, the pattern field within a tour step provides a mechanism to associate a step with specific code content rather than a fixed, ordinal line number [1][2][3]. This allows tours to remain resilient to code changes, as the step will anchor to a line matching the provided regular expression even if its absolute line number shifts over time [4][5]. The semantics of the pattern field are defined as follows: 1. Matching Priority: The pattern field is only evaluated if the line property is not set for that specific tour step [1][2][3]. If both are provided, the line property takes precedence and the pattern is ignored [1][2]. 2. Functionality: The value assigned to pattern must be a valid regular expression [1][2]. When a user navigates to the step, CodeTour searches the associated file for the first line that matches this regex [2][3]. 3. Configuration and Best Practices: - Record Mode: VS Code can be configured to use pattern-based association automatically when recording new tours by setting the CodeTour: Record Mode configuration to pattern (defaults to lineNumber) [3]. - Reliability: Because patterns rely on regex matching, it is recommended to ensure that every pattern regex compiles correctly and matches at least one line within the target file [5]. - Environment Considerations: CodeTour has historically addressed environment-specific limitations, such as ensuring compatibility with browsers or environments that do not support certain regex features like lookbehinds [6]. By using pattern instead of line, tour creators can create more robust documentation that does not break whenever code is added or removed from the source files [4][5].
Citations:
Use a pattern that matches
IDisp/DALDB.cs.The pattern
"this is the code"matches no line in the file. Replace it with"partial class DALDB"or add a validlineanchor.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Replace the placeholder package description.
nuget.txtcontains onlyPackage Description. The published pagev2/rscg_examples_site/docs/RSCG-Examples/serde.mddisplays this text at Lines [27-29]. Add the actual package description.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use patterns that exist in the target files.
Neither
Person.csnorProgram.cscontainsthis is the code. These steps cannot select the intended locations. Replace the placeholders with stable patterns such as[GenerateSerde]andJsonSerializer.Serialize.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use
p1for the deserialization output.Both examples print the original
pobject after deserialization. Update the source and its documentation copy.v2/rscg_examples/serde/src/Serializer/Program.cs#L8-L8: printp1.Name.v2/rscg_examples_site/docs/RSCG-Examples/serde.md#L148-L148: printp1.Name.📍 Affects 2 files
v2/rscg_examples/serde/src/Serializer/Program.cs#L8-L8(this comment)v2/rscg_examples_site/docs/RSCG-Examples/serde.md#L148-L148🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.