IBX-12340: Pass the required struct option when registering from invitation - #140
Open
vidarl wants to merge 1 commit into
Open
IBX-12340: Pass the required struct option when registering from invitation#140vidarl wants to merge 1 commit into
vidarl wants to merge 1 commit into
Conversation
|
This was referenced Aug 27, 2026
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
August 27, 2026 08:07
Steveb-p
reviewed
Aug 27, 2026
Comment on lines
+57
to
+65
| // Fixtures are imported once per run, so without this the invitation survives into | ||
| // InvitationServiceTest, which asserts absolute findInvitations() counts and fails | ||
| $connection = self::getDoctrineConnection(); | ||
| $connection->executeStatement( | ||
| 'DELETE FROM ibexa_user_invitation_assignment WHERE invitation_id IN ' | ||
| . '(SELECT id FROM ibexa_user_invitation WHERE email = :email)', | ||
| ['email' => self::INVITEE_EMAIL] | ||
| ); | ||
| $connection->delete('ibexa_user_invitation', ['email' => self::INVITEE_EMAIL]); |
Contributor
There was a problem hiding this comment.
What fixture? We are creating an invitation as part of the above test, and DAMADoctrineBundle should cause the transaction to be rolled back after it - this cleanup should not be necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Strictly speaking not related, but needed in order to make the invite user functionality work end-to-end (IBX-12339):
Description:
UserRegisterController::registerFromInvitationAction()buildsUserRegisterTypewithout thestructoption, so/from-invite/register/{hash}always returns HTTP 500 and an invitation can never be accepted.UserRegisterType::getParent()isBaseContentType, which declares->setRequired(['languageCode', 'mainLanguageCode', 'struct'])and forwardsstructinto everyfieldsDataentry.registerAction()in the same controller passes'struct' => $data; the invitation variant does not.Added the missing option, matching
registerAction().For QA:
See ticket for how to reproduce
Documentation: