NAS-142108 / 27.0.0-BETA.1 / Feat/shared check-member & prepare action - #2
Merged
Conversation
A reusable call reports as "<caller job id> / <this job name>", so consumers put that whole string in branch protection. Renaming the job here stops their required check reporting, with nothing in their repo to explain it. The usage example still showed @v1. Consumers track master — the tag was retired rather than kept moving, since a v1 re-pointed at every merge is master with a force-push in front of it.
Collapses the near-identical claude.yml carried by all three consumers. They had drifted: claude-code-action v1.0.7 / v1.0.134 / v1.0.182, models claude-opus-4-8 / claude-opus-5 / action default, and a write-access gate present in two of the three. Notes on two design choices: - The action version is hardcoded rather than an input. `uses:` does not evaluate expressions, and a configurable version is how the three repos drifted in the first place. Bump here, re-tag, all callers move. - The API key is an explicit named secret rather than `secrets: inherit`, because the repos name it differently (CLAUDE_API_KEY vs CLAUDE_TOKEN). The member gate is inlined as a job instead of a second reusable workflow: relative `uses:` paths inside a reusable workflow resolve against the caller's repository, which is a footgun with no upside here. webui's check-ux-team.yml and ui-components' check-member.yml turned out to be byte-identical apart from `name:` — neither checked a team, both checked repo write access — so the gate needs no parameterisation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MMo51bM6QV14CK3Kgyp3DQ
bugclerk
changed the title
Contributor
william-gr
requested changes
Aug 7, 2026
william-gr
left a comment
william-gr
left a comment
Contributor
There was a problem hiding this comment.
Lets leave claude out for now please. me and Aaron are working on changes
…ems/ux-github-workflows into feat/shared-workflows
william-gr
approved these changes
Aug 10, 2026
AlexKarpov98
changed the title
Contributor
|
This PR has been merged and conversations have been locked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.