Skip to content

Re-scope the open activity log when the active list changes - #49

Merged
iTerminate merged 1 commit into
mainfrom
fix-activity-log-list-scope
Aug 14, 2026
Merged

Re-scope the open activity log when the active list changes#49
iTerminate merged 1 commit into
mainfrom
fix-activity-log-list-scope

Conversation

@iTerminate

Copy link
Copy Markdown
Owner

Summary

  • Fixes Activity log stays scoped to the list it was opened on after switching lists #48: the open activity log stayed scoped to whichever list it was opened on, ignoring subsequent list switches (and leaving/deleting/renaming the active list, setting a default, or toggling membership).
  • LogbookController.base_option closes its entity set over at build time; nothing told it to rebuild when current_list_name changed underneath it.

Changes

  • LogbookController.rebuild_options (new): swaps an open session's scope options and re-applies the active one, keeping the paged window/maximized state — a scope change in place, not a reopen.
  • HACLI._table_log_options / refresh_table_log_scope (new): builds fresh list/list_devices/cursor/cursor_device options from whatever the table currently shows; no-ops for a graph/i-scoped session, whose entity set is a deliberate snapshot.
  • Wired refresh_table_log_scope() into ListController.select_or_create, rename_list, the delete/set_default popup actions, apply_membership (guarded to the active list), and leaving a list via Escape.

Test plan

  • tests/unit/test_logbook_controller.pyrebuild_options re-applies the active option, preserves paging/maximized state, skips a follows_cursor option, no-ops with no session
  • tests/test_activity_log.py — switching lists re-scopes an open list/list_devices log, View All / leaving a list retitles it, switching into an empty list closes it, an i-opened log is untouched, toggling membership of the active list refreshes it
  • pytest (full suite, 1317 tests) passes
  • ruff check . / pyright clean

@iTerminate
iTerminate merged commit 4549cd2 into main Aug 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activity log stays scoped to the list it was opened on after switching lists

1 participant