Add a live activity log to the dashboard - #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DashboardScreenbecomes a thirdLogbookControllerhost alongsideHACLI's docked panel andGraphPreviewScreen's:aopens a docked activity log defaulting to the whole dashboard's entities,vnarrows the scope (dashboard/devices/cursor slot/cursor's device),fmaximizes it, and it follows the grid cursor as it moves.GraphPreviewScreen, the dashboard log is live, soLogbookControllernow lets the singleton WS logbook subscription hand off between two simultaneously live-capable, visible sessions (the main screen's panel stays-visiblebehind a pushed dashboard) — it follows whichever screen is on top and resyncs on close/screen transitions.←/→for cursor movement:[/]page while docked,←/→take over once maximized (the grid is hidden then).Test plan
pytest(full suite, 1297 tests) passesuv run pyright/uv run ruff check .cleantests/test_dashboard_activity_log.py(11 tests) covers open/close, edit-mode fallthrough to the slot popup, scope popup, maximize+paging, docked paging, the escape ladder, live stream append, subscription handoff with the main screen, and session cleanup on leaving the dashboardDashboardController.dashboard_entity_idsand forLogbookController's two-live-host handoff / torn-down-host tolerance