fix(ci): drop the unused top-level actions: read from scorecard-reusable - #602
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
|
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review ✅ ApprovedRemoves the unused top-level
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |



Outcome
Every caller of
scorecard-reusable.ymlpinned atbd0df9eaor later that grants the estate-defaultcontents: read(plus its own job needs) hits a 0-secondstartup_failure— OSSF Scorecard has never run once on enaction-engine (20/20), cadastra, or svalinn. This removes the cause at source.Cause
The estate-wide security-compliance sweep (
0ced540e) added top-levelpermissions: actions: readto this reusable. No job in the file uses it — the only job (scorecard) declares its own block (security-events: write,id-token: write). But a reusable's top-level permissions must be grantable by every caller, so the unused line broke callers that don't grantactions: read.rust-ci-reusable.ymldocuments the identical lesson from its own history ("the previousactions: readhere was used by no job in this file, so every caller granting onlycontents: readfailed to start").Differential: consent-aware-web + project-ovine pin
81dbf2dd(pre-sweep, top-levelcontents: readonly) → green. enaction-engine/cadastra/svalinn pinbd0df9ea(post-sweep) → all startup_fail.Change
Delete the unused
actions: read; keepcontents: read; comment mirrors rust-ci-reusable's. Strictly permission-narrowing — callers granting more are unaffected; callers granting less can now start.Scope note (no over-claim)
This helps callers only at the SHA they pin: repos pinned to
bd0df9eastay broken until they either re-pin past this fix or addactions: readcaller-side (enaction-engine#39 does the latter and merges independently). cadastra / svalinn / chronicles-of-slavia should re-pin to a ref containing this commit at their next standards bump.🤖 Generated with Claude Code