Skip to content

chore: fill or remove RSR template placeholders - #42

Merged
hyperpolymath merged 3 commits into
mainfrom
fix/rsr-placeholders
Jul 28, 2026
Merged

chore: fill or remove RSR template placeholders#42
hyperpolymath merged 3 commits into
mainfrom
fix/rsr-placeholders

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

openssf-compliance.yml fails when any of the thirteen files it checks still contains a {{PLACEHOLDER}} token. This clears them, with no invention.

  • Deleted the TEMPLATE INSTRUCTIONS (delete this block before publishing) comment — the template says to delete it, and it is where every legend line lived, so a large share of the reported tokens were the file documenting its own placeholders.
  • Filled what the repository itself supplies: owner and repo from the git remote, project name, year, forge, main branch, contact email.
  • Removed PGP and website lines. https://github.com/<user>.gpg returns HTTP 200 for every account; with no key uploaded the body is a stub reading "This user hasn't uploaded any GPG keys". No key is published for either account, and commit signing here is SSH — unrelated. The template sanctions this: "Optional: Remove sections that don't apply (e.g. PGP if you don't use it)."\n\nA security policy telling a researcher to encrypt to a key that does not exist is worse than one that does not mention encryption.\n\nWhere applicable, this also fixes a misrouted advisory URL. A previous just init copied already-filled templates out of squisher-corpus, so 51 repositories directed vulnerability reports to hyperpolymath/squisher-corpus — a repository unrelated to the code being reported, meaning the affected maintainer never saw them. Repointed from this repository's own git remote.

hyperpolymath and others added 3 commits July 26, 2026 14:48
openssf-compliance.yml fails when any of the thirteen files it checks
still contains a {{PLACEHOLDER}} token. This clears them.

Three kinds of change, no invention:

The "TEMPLATE INSTRUCTIONS (delete this block before publishing)" comment
is deleted. The template says to delete it, and it is where every legend
line lives -- so a large share of the reported tokens were the file
documenting its own placeholders, not real unfilled fields.

Tokens derivable from the repository are filled: owner and repo from the
git remote, project name, year, forge, main branch, contact email.

PGP and website lines are removed rather than filled, because nothing
true could go in them. https://github.com/<user>.gpg returns HTTP 200 for
every account; with no key uploaded the body is a stub reading "This user
hasnt uploaded any GPG keys". No key is published for either account
here, and commit signing in this estate is SSH, which is unrelated. Only
one repository in the estate has a domain, so {{WEBSITE}} likewise has no
correct value. The template sanctions this: "Optional: Remove sections
that dont apply (e.g. PGP if you dont use it)." A security policy telling
a researcher to encrypt to a key that does not exist is worse than one
that does not mention encryption.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@gitar-bot

gitar-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown
CI failed: 4 test/build failures across various OS containers caused by a duplicate 'utils' directory path in `src/main.sh` when sourcing privileges.sh; 1 infrastructure failure due to missing `tar` binary in the OpenSUSE Leap container.

Overview

A total of 5 CI log failures were analyzed, revealing two distinct issues: a change-related build failure affecting multiple container jobs due to an incorrect source path in a shell script, and an infrastructure failure in the OpenSUSE container due to a missing tar executable.

Failures

Incorrect Sourced Script Path in src/main.sh (confidence: high)

  • Type: build
  • Affected jobs: 90326845530, 90326845659, 90326845487, 90326845502
  • Related to change: yes
  • Root cause: In src/main.sh on line 17, source "${SCRIPT_DIR}/utils/utils/privileges.sh" evaluates to a duplicated utils directory segment, resulting in a No such file or directory error across Ubuntu, Fedora, and Alpine environments.
  • Suggested fix: Update line 17 in src/main.sh from source "${SCRIPT_DIR}/utils/utils/privileges.sh" to source "${SCRIPT_DIR}/utils/privileges.sh".

Missing tar Executable in OpenSUSE Container (confidence: high)

  • Type: infrastructure
  • Affected jobs: 90326845482
  • Related to change: unclear
  • Root cause: The OpenSUSE Leap 15.5 container image lacks the tar utility required by GitHub Actions (e.g. actions/checkout or setup steps) to extract downloaded archives.
  • Suggested fix: Ensure tar is installed in the OpenSUSE container image or added as a setup step via zypper install tar before running checkout actions.

Summary

  • Change-related failures: 4 jobs failed due to the incorrect source path in src/main.sh.
  • Infrastructure/flaky failures: 1 job failed due to missing tar in the OpenSUSE container environment.
  • Recommended action: Fix the path typo in src/main.sh to resolve the build failures across platforms, and check the OpenSUSE workflow definition to ensure tar is available.
Code Review ✅ Approved

Replaces template placeholders in security compliance files with repository-specific values and removes unused PGP and website sections to satisfy OpenSSF checks. No issues found.

Auto-approved and auto-merge armed: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria. — merges when pipeline and required approvals pass.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@gitar-bot

gitar-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚠️ Gitar auto-approved this PR but could not enable auto-merge: auto-merge is disabled for this repository — enable "Allow auto-merge" in the repository settings.

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR and enabled auto-merge (configure)

@gitar-bot gitar-bot Bot added the gitar-approved Added by Gitar label Jul 28, 2026
@hyperpolymath
hyperpolymath merged commit ef5e6af into main Jul 28, 2026
8 of 24 checks passed
@hyperpolymath
hyperpolymath deleted the fix/rsr-placeholders branch July 28, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitar-approved Added by Gitar

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant