fix(ci): add the SPDX headers the workflow linter requires - #689
Merged
Conversation
All 27 workflows were missing `# SPDX-License-Identifier:` on line 1, which is what `governance / Workflow security linter` was failing on across every open hypatia pull request. The check name reads as a pinning problem; it was not one — the pin and lockfile checks in that same job already pass. MPL-2.0, matching the 135 source files that already carry it. ⚠ Inserted at line 1 ONLY. A comment is valid there in every YAML document, including one opening with `---`. Positional insertion anywhere else is what produced 100 unparseable workflows across the estate in an earlier sweep, so each file is parsed after the edit rather than assumed. Verified: all 27 parse; the estate duplicate-key scanner reports them clean; `gh actions-lock --verify-local` still reports complete lockfile coverage (the header does not disturb the managed region); and the linter's own SPDX and permissions checks pass when reproduced locally.
This comment has been minimized.
This comment has been minimized.
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
hyperpolymath
added a commit
that referenced
this pull request
Aug 7, 2026
`#689` added `# SPDX-License-Identifier: MPL-2.0` to 27 workflows on the premise they had no SPDX header. They all had one — just not on **line 1**, the only place the linter looks (`head -1 | grep`). 24 already declared MPL-2.0 (duplicate, harmless). **Three declared `PMPL-1.0-or-later`**, where the added line shadowed the real licence as the first declaration: - `.github/workflows/governance.yml` - `.github/workflows/hypatia-scan.yml` - `.github/workflows/scorecard.yml` Each file's own identifier is moved to line 1 and the duplicate removed — no licence restated, none changed. **Verified**: 0 duplicate SPDX lines · 0 missing on line 1 · the 3 PMPL files keep PMPL · all 27 parse · `gh actions-lock --verify-local` reports complete coverage. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 27 workflows lacked
# SPDX-License-Identifier:on line 1 — the actual cause ofgovernance / Workflow security linterfailing on every open hypatia PR. The check name suggests a pinning problem; the pin and lockfile checks in that job already pass.MPL-2.0, matching the 135 source files that already carry it.
Verified locally
gh actions-lock --verify-local: complete lockfile coverage retained⚠ Header inserted at line 1 only, and each file parsed after editing — blind positional insertion is what produced 100 unparseable workflows in an earlier estate sweep.
🤖 Generated with Claude Code