-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore(security): gitleaks allowlist for triaged false positives #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
| # | ||
| # Gitleaks configuration β hyperpolymath/gitbot-fleet | ||
| # | ||
| # EXTENDS THE ESTATE BASELINE, it does not replace it. | ||
| # `.gitleaks-estate.toml` is staged into the workspace root by | ||
| # hyperpolymath/standards `.github/workflows/secret-scanner-reusable.yml` | ||
| # before the scan runs. gitleaks resolves `[extend] path` against the process | ||
| # CWD (verified β NOT relative to this file), which is the repository root. | ||
| # | ||
| # WHY THIS FILE IS LOCAL RATHER THAN IN THE ESTATE BASELINE. | ||
| # Every entry below is a blind spot. Held here, it blinds this repository only, | ||
| # and the justification sits beside the code it describes. Promoted to the | ||
| # estate baseline it would blind all 400+ repositories β so the baseline keeps | ||
| # only entries that are true everywhere (lockfiles, vendored bundles, published | ||
| # protocol constants). | ||
| # | ||
| # Each entry names WHAT THE VALUE IS. "This file is noisy" is not a reason; if | ||
| # an entry cannot say what the matched value actually is, the secret should be | ||
| # removed from the tree instead. | ||
| # | ||
| # Every finding suppressed here was triaged on 2026-08-06 by reading the | ||
| # matched line with the value redacted. Before adding an entry, plant a | ||
| # realistic secret in the same path and confirm it is STILL detected. | ||
|
|
||
| [extend] | ||
| path = ".gitleaks-estate.toml" | ||
|
|
||
| [allowlist] | ||
| description = "hyperpolymath/gitbot-fleet: locally justified exemptions, extending the estate baseline" | ||
|
|
||
|
|
||
| paths = [ | ||
| # Unit tests for cipherbot's hardcoded-secret DETECTOR. The fixtures must | ||
| # look like secrets or the tests cannot assert that the detector rejects | ||
| # them. | ||
| '''(^|/)bots/cipherbot/src/analyzers/config\.rs$''', | ||
|
|
||
| ] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π‘ Edge Case: Allowlist may miss secret-like test fixture weak_config.toml
The allowlist exempts only bots/cipherbot/src/analyzers/config.rs, but a sibling test fixture bots/cipherbot/tests/fixtures/weak_config.toml also contains a credential-shaped literal (password = "SuperSecretPassword123!") that exists purely to exercise the detector. If the estate baseline's rules flag this value, the gate will fail on this repo even though it is a false positive of the same class the PR is triaging. Confirm whether gitleaks flags this fixture and, if so, add an anchored path entry for it (e.g. '''(^|/)bots/cipherbot/tests/fixtures/weak_config.toml$''').
Was this helpful? React with π / π