chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest - #53
chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest#53hyperpolymath wants to merge 3 commits into
Conversation
…the rest
Estate top-up pass. Three separate things, none of which invents a value.
FILLED — every token with a single mechanical answer: OWNER, REPO, FORGE,
PROJECT, PACKAGE_NAME, PROJECT_NAME, AUTHOR, AUTHOR_EMAIL, CONDUCT_EMAIL,
AUTHOR_FIRST/LAST/INITIALS, CURRENT_YEAR, CURRENT_DATE, DATE, MAIN_BRANCH.
Identity comes from the git remote, dates from the clock, project name from the
README H1 where there is one.
Deliberately NOT filled, because more than one defensible answer exists and a
confident wrong value is worse than a visible gap: SECURITY_EMAIL (two competing
addresses are in use across the estate), RESPONSE_TIME, CONDUCT_TEAM (which
substitutes into "a {{CONDUCT_TEAM}} member", not English), WEBSITE,
PROJECT_DESCRIPTION, LANG_STACK.
DELETED — ARCHITECTURE.md, where it is byte-identical to the 346-copy estate
boilerplate (blob 607e3d8). Those 33 lines describe a src/ tests/ docs/
scripts/ config/ tree that this repo does not have, so the file is not merely
uninformative, it is wrong. Genuinely written ARCHITECTURE files are matched by
hash and left alone. No file beats a confidently false one.
CODEOWNERS — rewritten to the solo form mandated by
hyperpolymath/standards CODEOWNERS-POLICY.adoc Rule 1, which forbids a catch-all
line where the only owner is the sole maintainer. The estate's own
templates/CODEOWNERS contradicts that policy; the policy is versioned, dated and
resolves standards#55, so it wins. Files naming a genuine co-owner are Rule 2
and are untouched. Note @hyperpolymath and @metadatastician are the same person,
so a file naming the other account is a copy artifact that silently routed
review requests to the wrong account.
SURFACED — REQUIRES_INITIALISATION.md, and a priority action in
0-AI-MANIFEST.a2ml. Tokens that need a decision no script can make are left
visibly unfilled rather than faked or quietly deleted. The marker says what each
one is, which files it belongs in, why it was not done already, and that it must
be deleted only once the work is genuinely finished.
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
| ;; Copyright (c) 2026 Jonathan D.A. Jewell (hyperpolymath) <j.d.a.jewell@open.ac.uk> | ||
| ;; | ||
| ;; Guix package definition for {{PROJECT_NAME}} | ||
| ;; Guix package definition for What Is a2mliser? |
There was a problem hiding this comment.
🚨 Bug: Guix package/channel names and URLs broken by spaced project title
{{PROJECT_NAME}} was filled with the display title What Is a2mliser? and injected into Guix identifier and URL positions. (name "What Is a2mliser?") in guix.scm:21 and (name 'What Is a2mliser?) in .guix-channel:9 are invalid — Guix package/channel names cannot contain spaces or ?, and 'What Is a2mliser? parses as three separate data, so guix build -f guix.scm and guix pull fail. The home-page/url values https://github.com/hyperpolymath/What Is a2mliser? (guix.scm:66, .guix-channel:10,17) are also malformed and point at a nonexistent repo; the correct slug is a2mliser. Use the repo slug for names/URLs (a2mliser) rather than the README title.
Use the repo slug for the Guix package name and home-page; likewise set channel name 'a2mliser and url https://github.com/hyperpolymath/a2mliser in .guix-channel.:
(name "a2mliser")
...
(home-page "https://github.com/hyperpolymath/a2mliser")
- Apply fix
Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎
| @software{{{PROJECT_NAME}}_2026, | ||
| author = {{{AUTHOR_LAST}}, {{AUTHOR_FIRST}}}, | ||
| title = {{{PROJECT_NAME}}}, | ||
| @software{What Is a2mliser?_2026, |
There was a problem hiding this comment.
⚠️ Bug: CITATIONS.adoc has invalid BibTeX key and broken repo URLs
The BibTeX entry @software{What Is a2mliser?_2026, (docs/attribution/CITATIONS.adoc:8) is an invalid citation key — keys cannot contain spaces or ?, so BibTeX/biber parsing fails. The repository URLs https://github.com/hyperpolymath/What Is a2mliser? on lines 12, 19, 23, 27, 31 are also malformed 404 links; they should use the repo slug a2mliser. Use a slug-style key (e.g. a2mliser_2026) and replace the URLs with https://github.com/hyperpolymath/a2mliser.
Use the repo slug for the key and all github.com URLs throughout the file; keep the human title only in the title/prose fields.:
@software{a2mliser_2026,
author = {Jewell, Jonathan},
title = {What Is a2mliser?},
year = {2026},
url = {https://github.com/hyperpolymath/a2mliser},
license = {MPL-2.0}
}
- Apply fix
Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎
| # Dev Container image for What Is a2mliser? | ||
| # Base: Chainguard Wolfi (minimal, supply-chain-secure) | ||
| # Build: podman build -t {{PROJECT_NAME}}-dev -f .devcontainer/Containerfile . | ||
| # Build: podman build -t What Is a2mliser?-dev -f .devcontainer/Containerfile . |
There was a problem hiding this comment.
⚠️ Bug: Dev container WORKDIR path contains unquoted spaces
.devcontainer/Containerfile:27 sets WORKDIR /workspaces/What Is a2mliser?, creating a workspace directory whose name contains spaces and a ?. This diverges from the conventional slug-based /workspaces/<repo> path that VS Code Dev Containers / Codespaces expect, and the spaces/? cause quoting and shell-escaping problems for any tooling that references the workdir. Use the repo slug: WORKDIR /workspaces/a2mliser.
Use the repo slug for the container workspace path (and in the build -t example comment on line 6).:
WORKDIR /workspaces/a2mliser
- Apply fix
Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎
|
|
||
| [methodology.state-validation] | ||
| reject-if-contains = ["{{PLACEHOLDER}}", "{{PROJECT}}", "rsr-template-repo"] | ||
| reject-if-contains = ["{{PLACEHOLDER}}", "A2MLISER", "rsr-template-repo"] |
There was a problem hiding this comment.
💡 Bug: State-validation reject list now matches valid doc content 'A2MLISER'
.machine_readable/agent_instructions/methodology.a2ml:104 changes the reject-if-contains token from {{PROJECT}} to the literal A2MLISER. Since state validation now rejects any file containing the substring A2MLISER, legitimately filled content (e.g. # A2MLISER ABI/FFI Documentation produced by the same pass in docs/developer/ABI-FFI-README.adoc:4) could be falsely flagged as stale/template state. Prefer keeping a template marker such as {{PROJECT}} rather than the filled project name in a reject list.
Was this helpful? React with 👍 / 👎
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review 🚫 Blocked 0 resolved / 4 findingsAutomated estate top-up fills mechanical placeholders and removes generic boilerplate, but injects the display title with spaces into Guix channel names, BibTeX citation keys, and dev container workdirs, breaking identifiers and URLs. 🚨 Bug: Guix package/channel names and URLs broken by spaced project title📄 guix.scm:4 📄 guix.scm:10 📄 guix.scm:21 📄 guix.scm:66 📄 .guix-channel:4 📄 .guix-channel:9 📄 .guix-channel:10 📄 .guix-channel:17
Use the repo slug for the Guix package name and home-page; likewise set channel name 'a2mliser and url https://github.com/hyperpolymath/a2mliser in .guix-channel.
|
| Compact |
|
Important
Your trial ends in 5 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.
Was this helpful? React with 👍 / 👎 | Gitar
There was a problem hiding this comment.
Configure merge blocking · Maintainers can dismiss this review.
…t a value
The estate top-up sweep substituted {{PROJECT}} here along with every other
token. This line is a DETECTOR list: the comment above it says these rules
detect corrupt/template/stale state files, so the tokens named in it are the
ones whose PRESENCE means a state file is broken.
Substituting it did two things. It blinded the {{PROJECT}} leak detector, and it
made the detector reject any state file containing this repo's own uppercased
name — the opposite of what the rule is for.
Same failure class as a template recipe rewriting the incident record that
documents its own bug: substituting tokens inside a thing that is ABOUT tokens.
Nothing else in this PR changes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The previous commit on this branch was written by a script that read the file through a shell command substitution. $(...) strips trailing newlines and printf '%s' does not put one back, so the file lost its final newline and the diff showed "\ No newline at end of file". Content is otherwise byte-identical to that commit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
1 participant
Automated estate top-up. Nothing here invents a value.
Filled — every token with one mechanical answer (owner, repo, forge, author, dates, project name, main branch). Identity from the git remote, dates from the clock, name from the README H1.
Not filled, on purpose —
SECURITY_EMAIL(two competing addresses exist in the estate),RESPONSE_TIME,CONDUCT_TEAM(substitutes into "a {{CONDUCT_TEAM}} member", which is not English),WEBSITE,PROJECT_DESCRIPTION,LANG_STACK. More than one defensible answer exists, and a confident wrong value is worse than a visible gap.Deleted —
ARCHITECTURE.mdwhere it is byte-identical to the 346-copy estate boilerplate (blob607e3d8c). Those 33 lines describe asrc/ tests/ docs/ scripts/ config/tree this repo does not have. Matched by hash, so a genuinely written ARCHITECTURE can never be caught by it.CODEOWNERS — the solo form from
standards/CODEOWNERS-POLICY.adocRule 1, which forbids a catch-all where the only owner is the sole maintainer.templates/CODEOWNERScontradicts that policy; the policy is versioned, dated and resolvesstandards#55, so it wins. Genuine co-owners (Rule 2) are untouched.Surfaced —
REQUIRES_INITIALISATION.mdplus a priority action in0-AI-MANIFEST.a2ml, listing every remaining token, what it means, which files it belongs in, why it was not done already, and that it is to be deleted only when the work is genuinely complete.Built from a fresh clone of
origin/main, never a local checkout — several of those are dirty and hold unpushed commits.🤖 Generated with Claude Code