Add Diagnostic provider to Schema Validation, improve JSON Pointer handling and add Dialect support#7
Merged
srivastava-diya merged 5 commits intoJun 8, 2026
Conversation
srivastava-diya
changed the title
jdesrosiers
requested changes
Jun 5, 2026
jdesrosiers
left a comment
jdesrosiers
left a comment
Collaborator
There was a problem hiding this comment.
Let's start organizing our tests. There should be a separate test file for each feature. So, src/features/SchemaValidation.test.ts, src/features/SyntaxValidation.test.ts, etc.
Collaborator
Merging "main" into a feature branch can cause problems. Prefer rebasing feature branches and only merging into "main". |
srivastava-diya
force-pushed
the
feature/schema-validation
branch
from
9604708 to
d79aa9e
Compare
jdesrosiers
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on feedback from our call, i have made the following changes
build-server.ts: Added support for all JSON Schema dialects (draft-04 through draft-2020-12).SchemaValidation.ts: Replaced the instanceLocation.slice(2).split("/") path resolution withfindNodeByPointera helper Fn that uses @hyperjump/json-pointer'spointerSegmentsto correctly handle escape sequences and array indices.language-server.test.ts: Added test with property names containing / (escape sequence)