Skip to content

feat(dashboard): move tile fullscreen to a top-level toolbar icon#2720

Open
alex-fedotyev wants to merge 1 commit into
mainfrom
alex/dashboard-fullscreen-toolbar-icon
Open

feat(dashboard): move tile fullscreen to a top-level toolbar icon#2720
alex-fedotyev wants to merge 1 commit into
mainfrom
alex/dashboard-fullscreen-toolbar-icon

Conversation

@alex-fedotyev

Copy link
Copy Markdown
Contributor

Move the dashboard tile's fullscreen action out of the "More actions" menu and into a dedicated top-level toolbar icon, so viewing a tile fullscreen is one click instead of two.

Summary

Fullscreen is a primary action, so it now renders as an IconArrowsMaximize button directly in the tile toolbar next to the alert bell, instead of a Menu.Item in the kebab. Narrow tiles that collapse the whole toolbar into the menu keep the action there. The f keyboard shortcut and the tile-fullscreen-button test id are unchanged, so the existing e2e keeps working.

Test plan

  • eslint + tsc clean
  • manual: hover a tile; the fullscreen icon shows in the toolbar and opens the fullscreen view; f still toggles it
  • narrow tile: the toolbar collapses and fullscreen stays in the menu
  • light and dark themes

[ui-states: allow] Toolbar action button; no empty/loading/error states of its own.

Screenshots

toolbar, light

toolbar, dark

View fullscreen was a Menu.Item inside the tile's "More actions" kebab.
Promote it to a dedicated IconArrowsMaximize button in the toolbar next to
the alert bell, so it is one click instead of two. Narrow tiles that
collapse the toolbar keep fullscreen in the menu. The `f` shortcut and the
tile-fullscreen-button test id are unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Jul 23, 2026 4:14pm
hyperdx-storybook Ready Ready Preview, Comment Jul 23, 2026 4:14pm

Request Review

@changeset-bot

changeset-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e108f1f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Jul 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 1
  • Production lines changed: 21
  • Branch: alex/dashboard-fullscreen-toolbar-icon
  • Author: alex-fedotyev

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Moves the dashboard tile fullscreen action into the primary toolbar while preserving it in the collapsed toolbar menu.

  • Adds a dedicated fullscreen ActionIcon to the standard tile toolbar.
  • Retains the fullscreen Menu.Item for narrow tiles using the collapsed toolbar.
  • Adds a patch changeset for the user-facing dashboard improvement.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The regular toolbar invokes the existing fullscreen callback from its new dedicated icon, while the separate collapsed-toolbar menu continues to expose the same action for narrow tiles.

Important Files Changed

Filename Overview
packages/app/src/DBDashboardPage.tsx Relocates the standard tile fullscreen control while preserving the existing collapsed-toolbar action and callback.
.changeset/tile-fullscreen-toolbar-icon.md Accurately documents the user-facing toolbar change as a patch release.

Reviews (1): Last reviewed commit: "feat(dashboard): move tile fullscreen to..." | Re-trigger Greptile

@github-actions

Copy link
Copy Markdown
Contributor

E2E Test Results

All tests passed • 243 passed • 1 skipped • 943s

Status Count
✅ Passed 243
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

@github-actions

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This is a small, purely additive UI change. The fullscreen ActionIcon was promoted into the tile toolbar (packages/app/src/DBDashboardPage.tsx:743), the fullscreen Menu.Item was dropped from the expanded kebab, and the narrow-tile collapsed menu still exposes "View fullscreen" (:907). The new button calls the stable openFullscreen callback, which is present in the hoverToolbar dependency array, and the responsive CollapsedToolbarProvider renders either the toolbar suffix or the collapsed menu but never both, so there is no duplicate action or duplicate data-testid. The f hotkey and the tile-fullscreen-button test id are unchanged. No correctness, security, or reliability regressions were found.

🔵 P3 nitpicks (1)
  • packages/app/src/DBDashboardPage.tsx:746 — the icon-only fullscreen ActionIcon conveys its name only through a Tooltip, so assistive technology exposes no accessible name for the control.
    • Fix: add an aria-label="View fullscreen" to the ActionIcon (and consider applying the same to the adjacent tile-alerts-button / tile-actions-button, which share this gap).

Reviewers (1): direct-code-inspection.

Environment note: The sandboxed shell (bwrap) failed on every command in this session, so git and grep were unavailable; the multi-agent persona fan-out and diff computation could not run. This review was produced by reading the PR head file directly and reasoning about the change against its stated intent, so removed lines were inferred rather than diffed. A re-run in a working environment is advisable for full coverage.

Testing gaps:

  • No automated test was confirmed to assert the fullscreen action now renders as a top-level toolbar button rather than a kebab Menu.Item; if the existing e2e reaches tile-fullscreen-button by first opening the kebab, the unchanged test id alone would not guarantee the new interaction path is exercised — verify the e2e clicks the toolbar button directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant