fix(dashboard): draw an isolated time-chart series beyond the line-render cap#2719
fix(dashboard): draw an isolated time-chart series beyond the line-render cap#2719alex-fedotyev wants to merge 1 commit into
Conversation
getVisibleLineData applied HARD_LINES_LIMIT before the legend selection, so isolating or filtering to a series ranked past the cap sliced it out and left the chart empty while the legend and stats still listed it. Apply the selection first, then cap, so a chosen series always draws; an oversized manual selection is still bounded by the cap. Update the unit test that pinned the old drop-if-over-limit behavior and add selection-beats-cap and oversized-selection cases. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
review/tier-2
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Greptile SummaryFixes rendering of explicitly selected time-chart series beyond the normal line cap.
Confidence Score: 4/5The oversized-selection axis mismatch should be fixed before merging because invisible capped-out series can distort the displayed chart. Rendering now caps the filtered selection, but axis bounds continue to scan the uncapped selected data, allowing values from lines that are not drawn to determine the visible scale. packages/app/src/HDXMultiSeriesTimeChart.tsx Important Files Changed
Reviews (1): Last reviewed commit: "fix(dashboard): draw an isolated series ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| return lineData | ||
| .filter(ld => selectedSeriesNames.has(getSeriesDisplayName(ld))) | ||
| .slice(0, HARD_LINES_LIMIT); |
There was a problem hiding this comment.
When more than HARD_LINES_LIMIT series are selected and a capped-out series has an extreme value, rendering excludes that series but the domain calculation still scans it, causing invisible data to expand the y-axis and compress the visible lines.
Knowledge Base Used: App Components and Charts
Deep Review✅ No critical issues found. The change reorders 🔵 P3 nitpicks (1)
Reviewers (1): direct review across correctness, testing, maintainability, project-standards, performance, and TypeScript lenses. Testing gaps:
|
E2E Test Results✅ All tests passed • 241 passed • 1 skipped • 990s
Tests ran across 4 shards in parallel. |
1 participant
Fix a case where isolating or filtering a dashboard time-chart series to one that ranks beyond the per-chart line-render cap left the chart empty.
Summary
getVisibleLineDataapplied theHARD_LINES_LIMITcap before the legend selection, so selecting a series ranked past the cap (via isolate, checkbox filter, or table search) sliced it out and drew nothing, even though the legend and stats still listed it. Apply the selection first, then cap: an explicitly chosen series always draws, and an oversized manual selection stays bounded by the cap.Test plan
eslint+tsccleangetVisibleLineDatacovers the no-selection cap, selection-beats-cap, and the oversized-selection bound (HDXMultiSeriesTimeChart.test.ts)[ui-check: allow] Selection-ordering fix in a pure helper; no visual or theme-dependent change, and the behavior is covered by unit tests.