Preserve struck words in the HTML/JSON round-trip (#403 Phase A) - #453
Open
maboa wants to merge 2 commits into
Open
Preserve struck words in the HTML/JSON round-trip (#403 Phase A)#453maboa wants to merge 2 commits into
maboa wants to merge 2 commits into
Conversation
… settings (#403) The converter dropped redactions (inline line-through) on both directions, so any JSON export/import silently resurrected every cut. Words now carry "struck": true (default not serialized). editor-audio-cut.js exposes getGapRemovalSettings/applyGapRemovalSettings so a loaded project can restore them through the normal UI path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First slice of the #403 Phase A sequence — cherry-picked from #404 so this data-integrity fix lands independently of the storage work.
The HTML↔JSON converter dropped redactions (inline line-through) in both directions, so any JSON export/import silently resurrected every cut. Words now carry
struck: true(default not serialized), andeditor-audio-cut.jsexposesgetGapRemovalSettings/applyGapRemovalSettingsso a loaded project can restore gap-removal state through the normal UI path.Conflict resolved against
main: #406's escaping landed on the same serializer line after this branched — the resolution composes both (strike attribute + escaped text), and a new unit test pins exactly that composition.Tests: 45 unit / 70 e2e green.