feat: support selective tensor dump by tensor argument#844
Open
zmnobug wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a selective tensor dump feature, allowing users to dump inputs and outputs for specific tasks by enabling a selective mode and marking individual tasks. The implementation adds bitmask-based request flags to task metadata and updates the AICPU collection logic to filter tasks accordingly. Review feedback suggests adding defensive null checks for the runtime context in the orchestration API to prevent potential crashes and using bitwise OR assignment for consistency in setting dump requests to avoid accidentally clearing flags.
zmnobug
force-pushed
the
feature/838-partial-task-tensor-dump
branch
2 times, most recently
from
b76483f to
7c039c7
Compare
zmnobug
changed the title
zmnobug
force-pushed
the
feature/838-partial-task-tensor-dump
branch
from
7c039c7 to
078a128
Compare
| #include <stdbool.h> | ||
| #endif | ||
|
|
||
| #ifndef TENSOR_DUMP_AICPU_CONTROL_ONLY |
zmnobug
force-pushed
the
feature/838-partial-task-tensor-dump
branch
2 times, most recently
from
d63722e to
fd0f1dc
Compare
Collaborator
There was a problem hiding this comment.
刚刚的评论的那一行，是指不用那一个单独的dump宏，__cplusplus还是需要的，这里也不用新增一个文件把接口拿出来
- Add platform-owned selective tensor dump controls - Add Arg::dump(...) to mark tensor arguments for task-level dump - Carry dump argument masks through task payloads and dump records - Skip unmarked tasks and unselected tensor args during AICPU collection - Add selective tensor dump regression coverage and documentation
zmnobug
force-pushed
the
feature/838-partial-task-tensor-dump
branch
from
fd0f1dc to
7e4ad76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rt_tensor_dump_selective()to enable selective tensor dump mode.Arg::dump(...)to select specific tensor arguments in a task.Testing
Fixes #838