[serge] Fix 2 integration tests for model moshi failing with OOM (other (2)) - #48581
Open
sergereview[bot] wants to merge 2 commits into
Open
[serge] Fix 2 integration tests for model moshi failing with OOM (other (2))#48581sergereview[bot] wants to merge 2 commits into
moshi failing with OOM (other (2))#48581sergereview[bot] wants to merge 2 commits into
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: moshi |
Contributor
CI recapDashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original CI failure
2 integration tests for modelmoshifailing withOOM(other (2))tests/models/moshi/test_modeling_moshi.py::MoshiIntegrationTests::test_moshiko_greedy_unconditional_fp16— retained memory (fixable): needed 64 MiB, PyTorch already held 21.89 GiB of 22.30 GiBCI traceback —
tests/models/moshi/test_modeling_moshi.py::MoshiIntegrationTests::test_moshiko_greedy_unconditional_fp16Where to watch it:
Relates to #48579
MoshiIntegrationTests::test_moshiko_greedy_unconditional_fp16andfp32fail with CUDA OOM because earlier tests in the same class leave models on the GPU; the 34–64 MiB allocation fails only because the device is already full.Add a class-wide
tearDownthat callscleanup(torch_device, gc_collect=True)after each test, matching the repo's idiom for large-model integration tests.Possibly related
Existing issues/PRs mentioning
test_moshiko_greedy_unconditional_fp16(keyword match — not verified to share a root cause):This change was produced automatically by serge from a CI failure report. The patch was generated by an LLM and applied by serge; review before merging.
serge
v0.1.0· model:moonshotai/Kimi-K2.7-Code· 21 LLM turns · 20 tool calls · 28.9s · 217201 in / 2015 out tokens