Conversation
| PCT_DISPLAY=$(printf '%.1f' "$PCT") | ||
| if [ "$PCT_INT" -ge 80 ]; then | ||
| EMOJI=":white_check_mark:" | ||
| elif [ "$PCT_INT" -ge 70 ]; then |
There was a problem hiding this comment.
Open to other percentages.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
|
||
| env: | ||
| UV_PYTHON_PREFERENCE: only-managed | ||
| COVERAGE_CELL: ${{ matrix.python-version == '3.10' && matrix.torch-version == '2.12.0' }} |
There was a problem hiding this comment.
Only run for a single path. But can increase it.
There was a problem hiding this comment.
Doing a single path sounds good to me!
danieldk
left a comment
danieldk
left a comment
There was a problem hiding this comment.
Looks good, some nits about the naming, feel free to ignore.
| fi | ||
|
|
||
| EXISTING=$(gh api "repos/${REPO}/issues/${PR_NUMBER}/comments" --paginate \ | ||
| --jq 'first(.[] | select(.body | startswith("<!-- coverage-report -->")) | .id) // empty') |
There was a problem hiding this comment.
What if a user makes a comment with that marker? I don't think there is an issue, since it'd just overwrite their comment?
There was a problem hiding this comment.
Good catch. Addressed.
|
|
||
| env: | ||
| UV_PYTHON_PREFERENCE: only-managed | ||
| COVERAGE_CELL: ${{ matrix.python-version == '3.10' && matrix.torch-version == '2.12.0' }} |
There was a problem hiding this comment.
Doing a single path sounds good to me!
Co-authored-by: Daniël de Kok <me@danieldk.eu>
|
There is an unrelated failure in the CI. I will fix it later. @danieldk |
3 participants
Some in-line comments.
Should we also run coverage on
mainpushes and keep a status on README? I think we don't need it. Open to suggestions.