ModularPipeline.save_pretrained: change the default overwrite_modular_index to be True - #14659
Open
yiyixuxu wants to merge 2 commits into
Open
ModularPipeline.save_pretrained: change the default overwrite_modular_index to be True#14659yiyixuxu wants to merge 2 commits into
overwrite_modular_index to be True#14659yiyixuxu wants to merge 2 commits into
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @DN6
Just a proposal, but I think since
save_pretrainednow saves the loaded components by default, it makes sense foroverwrite_modular_indexto default toTrueas well — otherwise the result is not very intuitive: e.g. when you runthe components are all saved into
local_dir, but itsmodular_model_index.jsonstill points atrepo_id— so reloading from the local_dir still fetch everything from hub even though weights are in the local folderIt's especially confusing if you intended to save a self-contained local copy with some custom components
See related issues: #14251, #14640