Accommodate custom components in maybe_raise_or_warn#13458
Open
neo wants to merge 1 commit intohuggingface:mainfrom
Open
Accommodate custom components in maybe_raise_or_warn#13458neo wants to merge 1 commit intohuggingface:mainfrom
maybe_raise_or_warn#13458neo wants to merge 1 commit intohuggingface:mainfrom
Conversation
by using `get_class_obj_and_candidates`
Member
|
What is the use case for this? |
Author
so not only instantiated diffusers components can be passed into a pipeline: but also for custom components in the same way: |
Member
|
What error do we get without this change? |
neo
commented
Apr 13, 2026
| ): | ||
| """Simple helper method to raise or warn in case incorrect module has been passed""" | ||
| if not is_pipeline_module: | ||
| library = importlib.import_module(library_name) |
Author
There was a problem hiding this comment.
What error do we get without this change?
It would raise here because it's not real library but custom component/module
and as you can see from def get_class_obj_and_candidates, it's the same logic but with added condition to get_class_from_dynamic_module — I think it should've used this util from the beginning, maybe the util was added after this piece of code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
by using
get_class_obj_and_candidates, this now can also check against custom components being passed in and not error out as not found.side note
I also noticed the second argument
libraryfrommaybe_raise_or_warnisn't being used, and we might want to remove it if we don't plan to use it later?Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.