Skip to content

fix: QwenImage pipelines silently disable CFG with pre-computed negative_prompt_embeds #13449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ricardo-M-L wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: QwenImage pipelines silently disable CFG with pre-computed negative_prompt_embeds #13449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/diffusers/pipelines/qwenimage/pipeline_qwenimage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ def __call__(
device = self._execution_device

has_neg_prompt = negative_prompt is not None or (
negative_prompt_embeds is not None and negative_prompt_embeds_mask is not None
negative_prompt_embeds is not None
)

if true_cfg_scale > 1 and not has_neg_prompt:
Expand Down
2 changes: 1 addition & 1 deletion src/diffusers/pipelines/qwenimage/pipeline_qwenimage_controlnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,7 @@ def __call__(
device = self._execution_device

has_neg_prompt = negative_prompt is not None or (
negative_prompt_embeds is not None and negative_prompt_embeds_mask is not None
negative_prompt_embeds is not None
)

if true_cfg_scale > 1 and not has_neg_prompt:
Expand Down
2 changes: 1 addition & 1 deletion src/diffusers/pipelines/qwenimage/pipeline_qwenimage_controlnet_inpaint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,7 +740,7 @@ def __call__(
device = self._execution_device

has_neg_prompt = negative_prompt is not None or (
negative_prompt_embeds is not None and negative_prompt_embeds_mask is not None
negative_prompt_embeds is not None
)
do_true_cfg = true_cfg_scale > 1 and has_neg_prompt
prompt_embeds, prompt_embeds_mask = self.encode_prompt(
Expand Down
2 changes: 1 addition & 1 deletion src/diffusers/pipelines/qwenimage/pipeline_qwenimage_edit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ def __call__(
image = image.unsqueeze(2)

has_neg_prompt = negative_prompt is not None or (
negative_prompt_embeds is not None and negative_prompt_embeds_mask is not None
negative_prompt_embeds is not None
)

if true_cfg_scale > 1 and not has_neg_prompt:
Expand Down
2 changes: 1 addition & 1 deletion src/diffusers/pipelines/qwenimage/pipeline_qwenimage_edit_inpaint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,7 +879,7 @@ def __call__(
image = image.to(dtype=torch.float32)

has_neg_prompt = negative_prompt is not None or (
negative_prompt_embeds is not None and negative_prompt_embeds_mask is not None
negative_prompt_embeds is not None
)

if true_cfg_scale > 1 and not has_neg_prompt:
Expand Down
2 changes: 1 addition & 1 deletion src/diffusers/pipelines/qwenimage/pipeline_qwenimage_edit_plus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,7 @@ def __call__(
vae_images.append(self.image_processor.preprocess(img, vae_height, vae_width).unsqueeze(2))

has_neg_prompt = negative_prompt is not None or (
negative_prompt_embeds is not None and negative_prompt_embeds_mask is not None
negative_prompt_embeds is not None
)

if true_cfg_scale > 1 and not has_neg_prompt:
Expand Down
2 changes: 1 addition & 1 deletion src/diffusers/pipelines/qwenimage/pipeline_qwenimage_img2img.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,7 @@ def __call__(
device = self._execution_device

has_neg_prompt = negative_prompt is not None or (
negative_prompt_embeds is not None and negative_prompt_embeds_mask is not None
negative_prompt_embeds is not None
)

if true_cfg_scale > 1 and not has_neg_prompt:
Expand Down
2 changes: 1 addition & 1 deletion src/diffusers/pipelines/qwenimage/pipeline_qwenimage_inpaint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@ def __call__(
device = self._execution_device

has_neg_prompt = negative_prompt is not None or (
negative_prompt_embeds is not None and negative_prompt_embeds_mask is not None
negative_prompt_embeds is not None
)

if true_cfg_scale > 1 and not has_neg_prompt:
Expand Down
2 changes: 1 addition & 1 deletion src/diffusers/pipelines/qwenimage/pipeline_qwenimage_layered.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,7 @@ def __call__(
batch_size = prompt_embeds.shape[0]

has_neg_prompt = negative_prompt is not None or (
negative_prompt_embeds is not None and negative_prompt_embeds_mask is not None
negative_prompt_embeds is not None
)

if true_cfg_scale > 1 and not has_neg_prompt:
Expand Down
Loading