-
Notifications
You must be signed in to change notification settings - Fork 776
Add missing setter methods to GHTeam #2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mvanhorn
wants to merge
2
commits into
hub4j:main
Choose a base branch
from
mvanhorn:feat/ghteam-update-methods
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,6 +34,28 @@ public enum Privacy { | |
| UNKNOWN | ||
| } | ||
|
|
||
| /** | ||
| * Notification setting for a team. Controls whether members receive notifications when the team is mentioned. | ||
| */ | ||
| public enum NotificationSetting { | ||
|
|
||
| /** Notifications enabled: members receive notifications when the team is @mentioned. */ | ||
| NOTIFICATIONS_ENABLED("notifications_enabled"), | ||
| /** Notifications disabled: mentions of the team do not generate notifications. */ | ||
| NOTIFICATIONS_DISABLED("notifications_disabled"); | ||
|
|
||
| private final String apiValue; | ||
|
|
||
| NotificationSetting(String apiValue) { | ||
| this.apiValue = apiValue; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return apiValue; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Member's role in a team. | ||
| */ | ||
|
|
@@ -511,6 +533,58 @@ public void setPrivacy(Privacy privacy) throws IOException { | |
| root().createRequest().method("PATCH").with("privacy", privacy).withUrlPath(api("")).send(); | ||
| } | ||
|
|
||
| /** | ||
| * Sets the team's name. | ||
| * | ||
| * @param name | ||
| * the new name | ||
| * @throws IOException | ||
| * the io exception | ||
| */ | ||
| public void setName(String name) throws IOException { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We're moving to not have set methods on objects. I don't see any on here yet... |
||
| root().createRequest().method("PATCH").with("name", name).withUrlPath(api("")).send(); | ||
| } | ||
|
|
||
| /** | ||
| * Sets the team's notification setting. | ||
| * | ||
| * @param notificationSetting | ||
| * the notification setting | ||
| * @throws IOException | ||
| * the io exception | ||
| */ | ||
| public void setNotificationSetting(NotificationSetting notificationSetting) throws IOException { | ||
| root().createRequest() | ||
| .method("PATCH") | ||
| .with("notification_setting", notificationSetting.toString()) | ||
| .withUrlPath(api("")) | ||
| .send(); | ||
| } | ||
|
|
||
| /** | ||
| * Sets the team's permission. | ||
| * | ||
| * @param permission | ||
| * the permission | ||
| * @throws IOException | ||
| * the io exception | ||
| */ | ||
| public void setPermission(GHOrganization.Permission permission) throws IOException { | ||
| root().createRequest().method("PATCH").with("permission", permission).withUrlPath(api("")).send(); | ||
| } | ||
|
|
||
| /** | ||
| * Sets the team's parent team by ID. | ||
| * | ||
| * @param parentTeamId | ||
| * the ID of the parent team, or {@code null} to remove the parent | ||
| * @throws IOException | ||
| * the io exception | ||
| */ | ||
| public void setParentTeamId(Long parentTeamId) throws IOException { | ||
| root().createRequest().method("PATCH").with("parent_team_id", parentTeamId).withUrlPath(api("")).send(); | ||
| } | ||
|
|
||
| private String api(String tail) { | ||
| if (organization == null) { | ||
| // Teams returned from pull requests to do not have an organization. Attempt to use url. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enums must have an UNKNOWN. See other enums such as PRIVACY and their usage.
You probably don't need the string either as Jackson will automatically convert for you.