-
Notifications
You must be signed in to change notification settings - Fork 1
Replace dependency @material-ui/styles with @mui/styles ^5.0.0 #12488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,7 +40,7 @@ | |
| "@backstage/version-bridge": "workspace:^", | ||
| "@material-ui/core": "^4.12.2", | ||
| "@material-ui/lab": "4.0.0-alpha.61", | ||
| "@material-ui/styles": "^4.11.0", | ||
| "@mui/styles": "^5.0.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Severity: medium Other Locations
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage. |
||
| "@types/react": "^16.13.1 || ^17.0.0", | ||
| "jss": "~10.10.0", | ||
| "lodash": "^4.17.21", | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package still imports from
@material-ui/styles(e.g.plugins/techdocs-react/src/component.tsx), so replacing the declared dependency here may cause repo/package dependency checks to fail (or end up relying on transitive deps). Other locations where this applies:plugins/code-coverage/package.json:36,plugins/sonarqube/package.json:47,plugins/techdocs/package.json:51.Severity: high
Other Locations
plugins/code-coverage/package.json:36plugins/sonarqube/package.json:47plugins/techdocs/package.json:51🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.