-
Notifications
You must be signed in to change notification settings - Fork 1
Update dependency octokit to v3 [SECURITY] #12482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,7 +33,7 @@ | |
| "@material-ui/icons": "^4.9.1", | ||
| "@material-ui/lab": "4.0.0-alpha.61", | ||
| "luxon": "^3.0.0", | ||
| "octokit": "^2.0.4", | ||
| "octokit": "^3.0.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Octokit v3 uses conditional exports and documents needing TS Severity: medium Other Locations
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage. |
||
| "react-use": "^17.4.0" | ||
| }, | ||
| "peerDependencies": { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,7 +88,7 @@ | |
| "morgan": "^1.10.0", | ||
| "node-fetch": "^2.6.7", | ||
| "nunjucks": "^3.2.3", | ||
| "octokit": "^2.0.0", | ||
| "octokit": "^3.0.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Severity: high Other Locations
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Octokit v3 release notes mention removing REST API preview support; Severity: medium 🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage. |
||
| "octokit-plugin-create-pull-request": "^3.10.0", | ||
| "p-limit": "^3.1.0", | ||
| "p-queue": "^6.6.2", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correctness: Upgrading
octokitfrom^2.0.4to^3.0.0is a major version bump that likely includes breaking API changes, but no source file changes are included in this PR to update the plugin's usage of the octokit API — this risks runtime failures if any removed or renamed APIs are called.🤖 AI Agent Prompt for Cursor/Windsurf