Repository navigation
Format JSON bodies regardless of MIME type casing - #1977
Open
charan-rathore wants to merge 1 commit into
Open
charan-rathore wants to merge 1 commit into
charan-rathore wants to merge 1 commit into
Conversation
JSONFormatter matched the content type case-sensitively, so a response declared as APPLICATION/JSON (or any other casing) was printed raw instead of being pretty-printed. Lower-case the MIME string before matching, as RFC 9110 media types are case-insensitive. Fixes httpie#1958. Signed-off-by: Charan Rathore <180254320+charan-rathore@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1958.
JSONFormatter.format_bodymatches the response MIME type againstjson/javascript/texttokens case-sensitively, so a server declaringAPPLICATION/JSON(or any non-lowercase casing) gets its body printed raw instead of pretty-printed. Media types are case-insensitive (RFC 9110), so the MIME string is now lower-cased before matching. Displayed content is untouched.Added
TestJSONFormatterMIMEintests/test_output.py:application/json,APPLICATION/JSON, andApplication/Problem+JSON; charset=UTF-8all produce multi-line output that parses back to the original object, plus a parity check that upper-cased non-JSON MIME types behave exactly like their lower-case forms.Verified: the case-insensitive tests fail without the change and pass with it; full
tests/test_output.pypasses (126 passed, 3 xfailed).