Skip to content

Fix LazyChoices for Python 3.14+ — avoid eager getter call during parser registration #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
driphtyio wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix LazyChoices for Python 3.14+ — avoid eager getter call during parser registration #1894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion httpie/cli/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import argparse
from argparse import ArgumentError
from typing import Any, Callable, Generic, Iterator, Iterable, Optional, TypeVar

T = TypeVar('T')
Expand Down Expand Up @@ -44,7 +45,6 @@ def __init__(
self._help: Optional[str] = None
self._obj: Optional[Iterable[T]] = None
super().__init__(*args, **kwargs)
self.choices = self

def load(self) -> T:
if self._obj is None or not self.cache:
Expand Down Expand Up @@ -76,4 +76,9 @@ def __iter__(self) -> Iterator[T]:
return iter(self.load())

def __call__(self, parser, namespace, values, option_string=None):
if values not in self.load():
raise ArgumentError(
self,
f"invalid choice: {values!r} (choose from {self.load()!r})"
)
setattr(namespace, self.dest, values)
Loading