Skip to content

Screens/Tabs/Signals panels: move const calc expression out of loop#2040

Open
GermanAizek wants to merge 1 commit into
htop-dev:mainfrom
GermanAizek:const-out-of-loop2
Open

Screens/Tabs/Signals panels: move const calc expression out of loop#2040
GermanAizek wants to merge 1 commit into
htop-dev:mainfrom
GermanAizek:const-out-of-loop2

Conversation

@GermanAizek

Copy link
Copy Markdown
Contributor

Reference: #2038

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 67d6235d-a159-4a58-b38d-502a3eb2f47f

📥 Commits

Reviewing files that changed from the base of the PR and between 1ef4226 and 9cb0374.

📒 Files selected for processing (3)
  • ScreenTabsPanel.c
  • ScreensPanel.c
  • SignalsPanel.c

📝 Walkthrough

Walkthrough

Changes

This PR makes three minor, unrelated code style adjustments across separate panel source files: declaring a loop-bound variable as const int in ScreenTabsPanel.c, caching a Panel_size() call into a local const int before a loop in ScreensPanel.c, and moving a loop variable declaration outside the for statement in SignalsPanel.c. No functional or public interface changes are introduced.

Sequence Diagram(s)

Not applicable — changes are limited to local variable declaration style with no altered control flow or interactions.

Compact Metadata

  • Type: Refactor / code style
  • Files changed: 3
  • Lines changed: +5/-3
  • Public API changes: None

Related Issues: None specified
Related PRs: None specified
Suggested Labels: refactor, low-risk
Suggested Reviewers: Not determinable from provided data

Poem

Three files, three tweaks, so small and neat,
Constants and hoists, a loop's quiet feat.
No behavior stirred, no bug set free,
Just tidier code for all to see. 🐇


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant