Skip to content

test(integration): cover category-A scenarios from #207#99

Merged
zfarrell merged 2 commits into
mainfrom
test/expand-integration-scenarios
Jun 5, 2026
Merged

test(integration): cover category-A scenarios from #207#99
zfarrell merged 2 commits into
mainfrom
test/expand-integration-scenarios

Conversation

@zfarrell

@zfarrell zfarrell commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Adds sdk-python integration tests for the 10 category-A scenarios defined in hotdata-dev/www.hotdata.dev#215: databases/contexts/catalogs lifecycle, embedding providers, connection types, jobs, information schema, uploads, managed tables, and saved-query reads. Each test is self-cleaning and prod-safe.

Note: embedding_providers_crud uses a credential-free service provider since the runtime rejects provider_type=local. Companion www PR still needs to drop python from optional_for on these scenarios to enforce them.

claude[bot]
claude Bot previously approved these changes Jun 5, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all 10 new scenario tests and the conftest fixtures. Method signatures and model attributes verified against the generated SDK; tests are self-cleaning, isolated via the scratch_database fixture, and consistent with existing integration conventions. LGTM.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: test-only PR adding 10 category-A integration scenarios plus supporting conftest fixtures. Verified all model attribute names, API method signatures, and response fields against the generated SDK source — all match. Fixtures are correctly scoped; mutating scenarios use isolated scratch databases with finally/expires_at cleanup and guarded ApiException teardown. No issues.

@zfarrell zfarrell merged commit 3fc2cdd into main Jun 5, 2026
7 checks passed
@zfarrell zfarrell deleted the test/expand-integration-scenarios branch June 5, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant